* [2.6 patch] #if 0 cx88_risc_disasm
2004-11-09 9:46 ` Gerd Knorr
@ 2004-11-10 2:32 ` Adrian Bunk
0 siblings, 0 replies; 2+ messages in thread
From: Adrian Bunk @ 2004-11-10 2:32 UTC (permalink / raw)
To: Gerd Knorr; +Cc: video4linux-list, linux-kernel
On Tue, Nov 09, 2004 at 10:46:48AM +0100, Gerd Knorr wrote:
>...
> > > moment automatically is useless. cx88_risc_disasm() for example is
> > > useful for debugging the driver. And that there is no in-kernel user
> >
> > But couldn't this be #if 0'ed?
>
> Yes, it could.
>...
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.10-rc1-mm4-full/drivers/media/video/cx88/cx88-core.c.old 2004-11-10 02:46:36.000000000 +0100
+++ linux-2.6.10-rc1-mm4-full/drivers/media/video/cx88/cx88-core.c 2004-11-10 02:47:15.000000000 +0100
@@ -462,6 +462,7 @@
return incr[risc >> 28] ? incr[risc >> 28] : 1;
}
+#if 0
void cx88_risc_disasm(struct cx88_core *core,
struct btcx_riscmem *risc)
{
@@ -479,6 +480,8 @@
break;
}
}
+EXPORT_SYMBOL(cx88_risc_disasm);
+#endif
void cx88_sram_channel_dump(struct cx88_core *core,
struct sram_channel *ch)
@@ -1197,8 +1200,6 @@
EXPORT_SYMBOL(cx88_risc_stopper);
EXPORT_SYMBOL(cx88_free_buffer);
-EXPORT_SYMBOL(cx88_risc_disasm);
-
EXPORT_SYMBOL(cx88_sram_channels);
EXPORT_SYMBOL(cx88_sram_channel_setup);
EXPORT_SYMBOL(cx88_sram_channel_dump);
^ permalink raw reply [flat|nested] 2+ messages in thread
* [2.6 patch] #if 0 cx88_risc_disasm
@ 2005-01-19 4:57 Adrian Bunk
0 siblings, 0 replies; 2+ messages in thread
From: Adrian Bunk @ 2005-01-19 4:57 UTC (permalink / raw)
To: Andrew Morton; +Cc: Gerd Knorr, video4linux-list, linux-kernel
This patch #if 0's the unused function cx88_risc_disasm.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
diffstat output:
drivers/media/video/cx88/cx88-core.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
This patch was already sent on:
- 10 Nov 2004
--- linux-2.6.10-rc1-mm4-full/drivers/media/video/cx88/cx88-core.c.old 2004-11-10 02:46:36.000000000 +0100
+++ linux-2.6.10-rc1-mm4-full/drivers/media/video/cx88/cx88-core.c 2004-11-10 02:47:15.000000000 +0100
@@ -462,6 +462,7 @@
return incr[risc >> 28] ? incr[risc >> 28] : 1;
}
+#if 0
void cx88_risc_disasm(struct cx88_core *core,
struct btcx_riscmem *risc)
{
@@ -479,6 +480,8 @@
break;
}
}
+EXPORT_SYMBOL(cx88_risc_disasm);
+#endif
void cx88_sram_channel_dump(struct cx88_core *core,
struct sram_channel *ch)
@@ -1197,8 +1200,6 @@
EXPORT_SYMBOL(cx88_risc_stopper);
EXPORT_SYMBOL(cx88_free_buffer);
-EXPORT_SYMBOL(cx88_risc_disasm);
-
EXPORT_SYMBOL(cx88_sram_channels);
EXPORT_SYMBOL(cx88_sram_channel_setup);
EXPORT_SYMBOL(cx88_sram_channel_dump);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-01-19 4:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-19 4:57 [2.6 patch] #if 0 cx88_risc_disasm Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2004-11-07 17:50 RFC: [2.6 patch] drivers/media/video/ cleanups Adrian Bunk
2004-11-08 11:40 ` Gerd Knorr
2004-11-09 0:43 ` Adrian Bunk
2004-11-09 9:46 ` Gerd Knorr
2004-11-10 2:32 ` [2.6 patch] #if 0 cx88_risc_disasm Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox