From: Jens Axboe <axboe@suse.de>
To: Michal Schmidt <xschmi00@stud.feec.vutbr.cz>
Cc: Peter Osterlund <petero2@telia.com>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fix verify_command to allow burning more than 1 DVD
Date: Wed, 19 Jan 2005 08:25:59 +0100 [thread overview]
Message-ID: <20050119072555.GQ6909@suse.de> (raw)
In-Reply-To: <41EDAD71.80203@stud.feec.vutbr.cz>
On Wed, Jan 19 2005, Michal Schmidt wrote:
> Peter Osterlund wrote:
> >Michal Schmidt <xschmi00@stud.feec.vutbr.cz> writes:
> >>--- linux-2.6.11-mm1/drivers/block/scsi_ioctl.c.orig 2005-01-17
> >>20:42:40.000000000 +0100
> >>+++ linux-2.6.11-mm1/drivers/block/scsi_ioctl.c 2005-01-17
> >>20:43:14.000000000 +0100
> >>@@ -197,9 +197,7 @@ static int verify_command(struct file *f
> >> if (type & CMD_WRITE_SAFE) {
> >> if (file->f_mode & FMODE_WRITE)
> >> return 0;
> >>- }
> >>-
> >>- if (!(type & CMD_WARNED)) {
> >>+ } else if (!(type & CMD_WARNED)) {
> >> cmd_type[cmd[0]] = CMD_WARNED;
> >> printk(KERN_WARNING "scsi: unknown opcode 0x%02x\n", cmd[0]);
> >> }
> >
> >
> >That patch will not write the warning message in some cases.
>
> Yes. In cases when the device is opened for reading and the command is
> known as safe_for_write.
> Do we really want to print this warning in that case?
No, the command should only be dumped if it is unknown and denied.
--
Jens Axboe
next prev parent reply other threads:[~2005-01-19 7:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-17 20:34 [PATCH] fix verify_command to allow burning more than 1 DVD Michal Schmidt
2005-01-18 22:43 ` Peter Osterlund
2005-01-19 0:44 ` Michal Schmidt
2005-01-19 7:25 ` Jens Axboe [this message]
2005-01-19 20:01 ` Dominique Simon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050119072555.GQ6909@suse.de \
--to=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=petero2@telia.com \
--cc=xschmi00@stud.feec.vutbr.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox