From: Rogier Wolff <R.E.Wolff@BitWizard.nl>
To: lkml@bitwizard.nl, greg@kroah.com, bryder@sgi.com,
kuba@mareimbrium.org, ftdi-usb-sio-devel@lists.sourceforge.net
Cc: edwin@harddisk-recovery.nl
Subject: Bug when using custom baud rates....
Date: Thu, 20 Jan 2005 15:54:22 +0100 [thread overview]
Message-ID: <20050120145422.GB18037@bitwizard.nl> (raw)
[-- Attachment #1: Type: text/plain, Size: 794 bytes --]
Hi,
When using custom baud rates, the code does:
if ((new_serial.baud_base != priv->baud_base) ||
(new_serial.baud_base < 9600))
return -EINVAL;
Which translates to english as:
If you changed the baud-base, OR the new one is
invalid, return invalid.
but it should be:
If you changed the baud-base, OR the new one is
invalid, return invalid.
Patch attached.
Roger.
--
** R.E.Wolff@BitWizard.nl ** http://www.BitWizard.nl/ ** +31-15-2600998 **
*-- BitWizard writes Linux device drivers for any device you may have! --*
Q: It doesn't work. A: Look buddy, doesn't work is an ambiguous statement.
Does it sit on the couch all day? Is it unemployed? Please be specific!
Define 'it' and what it isn't doing. --------- Adapted from lxrbot FAQ
[-- Attachment #2: ftdi_fix --]
[-- Type: text/plain, Size: 541 bytes --]
diff -ur linux-2.4.28.clean/drivers/usb/serial/ftdi_sio.c linux-2.4.28.ftdi_fix/drivers/usb/serial/ftdi_sio.c
--- linux-2.4.28.clean/drivers/usb/serial/ftdi_sio.c Wed Jan 19 16:31:03 2005
+++ linux-2.4.28.ftdi_fix/drivers/usb/serial/ftdi_sio.c Thu Jan 20 15:47:49 2005
@@ -981,7 +981,7 @@
goto check_and_exit;
}
- if ((new_serial.baud_base != priv->baud_base) ||
+ if ((new_serial.baud_base != priv->baud_base) &&
(new_serial.baud_base < 9600))
return -EINVAL;
Only in linux-2.4.28.ftdi_fix/drivers/usb/serial: ftdi_sio.c~
next reply other threads:[~2005-01-20 15:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-20 14:54 Rogier Wolff [this message]
[not found] ` <20050120150857.GH13036@kroah.com>
2005-01-20 15:22 ` Bug when using custom baud rates Rogier Wolff
2005-01-21 0:03 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050120145422.GB18037@bitwizard.nl \
--to=r.e.wolff@bitwizard.nl \
--cc=bryder@sgi.com \
--cc=edwin@harddisk-recovery.nl \
--cc=ftdi-usb-sio-devel@lists.sourceforge.net \
--cc=greg@kroah.com \
--cc=kuba@mareimbrium.org \
--cc=lkml@bitwizard.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox