From: Ingo Molnar <mingo@elte.hu>
To: George Anzinger <george@mvista.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] to fix xtime lock for in the RT kernel patch
Date: Fri, 21 Jan 2005 07:35:19 +0100 [thread overview]
Message-ID: <20050121063519.GA19954@elte.hu> (raw)
In-Reply-To: <41F04573.7070508@mvista.com>
* George Anzinger <george@mvista.com> wrote:
> It seems to me that we need to either do the attached or to rewrite
> the timer front end code to just gather the offset info and defer to
> the timer irq thread to update jiffies and the offset stuff. In
> either case we really can not split the two and we do need the
> xtime_lock protection.
how about the patch below? One of the important benefits of the threaded
timer IRQ is the ability to make xtime_lock a mutex.
Ingo
--- linux/arch/i386/kernel/time.c.orig2
+++ linux/arch/i386/kernel/time.c
@@ -313,6 +313,7 @@ irqreturn_t timer_interrupt(int irq, voi
write_seqlock(&xtime_lock);
cur_timer->mark_offset();
+ do_timer(regs);
do_timer_interrupt(irq, NULL, regs);
--- linux/include/asm-i386/mach-default/do_timer.h.orig2
+++ linux/include/asm-i386/mach-default/do_timer.h
@@ -16,7 +16,6 @@
static inline void do_timer_interrupt_hook(struct pt_regs *regs)
{
- do_timer(regs);
#ifndef CONFIG_SMP
update_process_times(user_mode(regs));
#endif
next prev parent reply other threads:[~2005-01-21 6:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-20 23:57 [PATCH] to fix xtime lock for in the RT kernel patch George Anzinger
2005-01-21 6:35 ` Ingo Molnar [this message]
2005-01-21 8:16 ` George Anzinger
2005-01-21 8:21 ` Ingo Molnar
2005-01-21 8:39 ` George Anzinger
2005-01-21 8:45 ` Ingo Molnar
2005-01-21 8:54 ` George Anzinger
2005-01-21 9:00 ` Ingo Molnar
2005-01-21 9:08 ` George Anzinger
2005-01-27 20:53 ` George Anzinger
2005-01-28 4:35 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050121063519.GA19954@elte.hu \
--to=mingo@elte.hu \
--cc=george@mvista.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox