From: Greg KH <greg@kroah.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: John Mock <kd6pag@qsl.net>, linux-kernel@vger.kernel.org
Subject: Re: 2.6.11-rc1 vs. PowerMac 8500/G3 (and VAIO laptop) [usb-storage oops]
Date: Thu, 20 Jan 2005 23:58:33 -0800 [thread overview]
Message-ID: <20050121075833.GA19995@kroah.com> (raw)
In-Reply-To: <1106293748.783.31.camel@baythorne.infradead.org>
On Fri, Jan 21, 2005 at 07:49:08AM +0000, David Woodhouse wrote:
> On Thu, 2005-01-20 at 16:08 -0800, Greg KH wrote:
> > Doh, sorry for missing this one. I've applied your patch to my trees,
> > and will show up in the next -mm release.
>
> Actually I think John's problem was that the usb core code has now
> _stopped_ doing this byteswapping, and he has a lsusb which is hacked to
> expect it. So if you apply my patch you're preserving the userspace ABI
> by reverting to the extremely stupid behaviour of byteswapping _some_ of
> the fields in the descriptor we pass to userspace.
Well, we should be byteswapping all of the fields that need to be
swapped, right? I'm guessing that userspace is expecting the fields to
be in cpu endian, correct?
But if you want, I'll gladly revert your patch, as I don't have a ppc
box to test this out on.
thanks,
greg k-h
next prev parent reply other threads:[~2005-01-21 8:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-19 23:39 2.6.11-rc1 vs. PowerMac 8500/G3 (and VAIO laptop) [usb-storage oops] John Mock
2005-01-20 8:40 ` David Woodhouse
2005-01-21 0:08 ` Greg KH
2005-01-21 7:49 ` David Woodhouse
2005-01-21 7:58 ` Greg KH [this message]
2005-01-21 8:12 ` David Woodhouse
2005-01-21 8:42 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2005-01-20 18:29 John Mock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050121075833.GA19995@kroah.com \
--to=greg@kroah.com \
--cc=dwmw2@infradead.org \
--cc=kd6pag@qsl.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox