From: Adrian Bunk <bunk@stusta.de>
To: Benoit Boissinot <benoit.boissinot@ens-lyon.org>
Cc: kernel-janitors <kernel-janitors@lists.osdl.org>,
linux-kernel@vger.kernel.org
Subject: [2.6 patch] generic_serial.h: kill incorrect gs_debug reference
Date: Fri, 21 Jan 2005 11:08:52 +0100 [thread overview]
Message-ID: <20050121100852.GF3209@stusta.de> (raw)
In-Reply-To: <20050120220402.GB22673@ens-lyon.fr>
On Thu, Jan 20, 2005 at 11:04:03PM +0100, Benoit Boissinot wrote:
> Hi,
>
> the following patch (against latest -mm), correct compilation errors with
> gcc-4.0 (snapshot 20050116).
>
> please correct me if i did something wrong, this is my first patch
> with the linux kernel.
>
> Benoit
>
> diff -Naurp --exclude=ctags linux-clean/drivers/char/generic_serial.c linux-2.6-mm-test/drivers/char/generic_serial.c
> --- linux-clean/drivers/char/generic_serial.c 2005-01-20 22:12:57.000000000 +0100
> +++ linux-2.6-mm-test/drivers/char/generic_serial.c 2005-01-20 21:27:11.000000000 +0100
> @@ -36,7 +36,7 @@
> static char * tmp_buf;
> static DECLARE_MUTEX(tmp_buf_sem);
>
> -static int gs_debug;
> +int gs_debug;
>...
This part seems to be wrong.
Correct patch below.
<-- snip -->
generic_serial.h contained an incorrect extern reference to the static
variable gs_debug (Benoit Boissinot reported that gcc 4.0 rejects this).
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.11-rc1-mm2-full/include/linux/generic_serial.h.old 2005-01-20 23:26:07.000000000 +0100
+++ linux-2.6.11-rc1-mm2-full/include/linux/generic_serial.h 2005-01-20 23:26:20.000000000 +0100
@@ -93,6 +93,4 @@
int gs_getserial(struct gs_port *port, struct serial_struct __user *sp);
void gs_got_break(struct gs_port *port);
-extern int gs_debug;
-
#endif
next parent reply other threads:[~2005-01-21 10:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20050120220402.GB22673@ens-lyon.fr>
2005-01-21 10:08 ` Adrian Bunk [this message]
2005-01-31 12:17 [2.6 patch] generic_serial.h: kill incorrect gs_debug reference Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050121100852.GF3209@stusta.de \
--to=bunk@stusta.de \
--cc=benoit.boissinot@ens-lyon.org \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox