* [2.6 patch] generic_serial.h: kill incorrect gs_debug reference
[not found] <20050120220402.GB22673@ens-lyon.fr>
@ 2005-01-21 10:08 ` Adrian Bunk
0 siblings, 0 replies; 2+ messages in thread
From: Adrian Bunk @ 2005-01-21 10:08 UTC (permalink / raw)
To: Benoit Boissinot; +Cc: kernel-janitors, linux-kernel
On Thu, Jan 20, 2005 at 11:04:03PM +0100, Benoit Boissinot wrote:
> Hi,
>
> the following patch (against latest -mm), correct compilation errors with
> gcc-4.0 (snapshot 20050116).
>
> please correct me if i did something wrong, this is my first patch
> with the linux kernel.
>
> Benoit
>
> diff -Naurp --exclude=ctags linux-clean/drivers/char/generic_serial.c linux-2.6-mm-test/drivers/char/generic_serial.c
> --- linux-clean/drivers/char/generic_serial.c 2005-01-20 22:12:57.000000000 +0100
> +++ linux-2.6-mm-test/drivers/char/generic_serial.c 2005-01-20 21:27:11.000000000 +0100
> @@ -36,7 +36,7 @@
> static char * tmp_buf;
> static DECLARE_MUTEX(tmp_buf_sem);
>
> -static int gs_debug;
> +int gs_debug;
>...
This part seems to be wrong.
Correct patch below.
<-- snip -->
generic_serial.h contained an incorrect extern reference to the static
variable gs_debug (Benoit Boissinot reported that gcc 4.0 rejects this).
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.11-rc1-mm2-full/include/linux/generic_serial.h.old 2005-01-20 23:26:07.000000000 +0100
+++ linux-2.6.11-rc1-mm2-full/include/linux/generic_serial.h 2005-01-20 23:26:20.000000000 +0100
@@ -93,6 +93,4 @@
int gs_getserial(struct gs_port *port, struct serial_struct __user *sp);
void gs_got_break(struct gs_port *port);
-extern int gs_debug;
-
#endif
^ permalink raw reply [flat|nested] 2+ messages in thread
* [2.6 patch] generic_serial.h: kill incorrect gs_debug reference
@ 2005-01-31 12:17 Adrian Bunk
0 siblings, 0 replies; 2+ messages in thread
From: Adrian Bunk @ 2005-01-31 12:17 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
generic_serial.h contained an incorrect extern reference to the static
variable gs_debug (Benoit Boissinot reported that gcc 4.0 rejects this).
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 21 Jan 2005
--- linux-2.6.11-rc1-mm2-full/include/linux/generic_serial.h.old 2005-01-20 23:26:07.000000000 +0100
+++ linux-2.6.11-rc1-mm2-full/include/linux/generic_serial.h 2005-01-20 23:26:20.000000000 +0100
@@ -93,6 +93,4 @@
int gs_getserial(struct gs_port *port, struct serial_struct __user *sp);
void gs_got_break(struct gs_port *port);
-extern int gs_debug;
-
#endif
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-01-31 12:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20050120220402.GB22673@ens-lyon.fr>
2005-01-21 10:08 ` [2.6 patch] generic_serial.h: kill incorrect gs_debug reference Adrian Bunk
2005-01-31 12:17 Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox