From: Adrian Bunk <bunk@stusta.de>
To: chas@cmf.nrl.navy.mil
Cc: linux-atm-general@lists.sourceforge.net, jgarzik@pobox.com,
linux-net@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [2.6 patch] drivers/atm/nicstar*: small cleanup
Date: Fri, 21 Jan 2005 13:42:18 +0100 [thread overview]
Message-ID: <20050121124218.GL3209@stusta.de> (raw)
This patch makes two needlessly global functions in nicstarmac.c static.
Since after this change nicstarmac.h contained only one typedef I've
moved this typedef to nicstarmac.c and completely removed the header.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/atm/nicstar.c | 1 -
drivers/atm/nicstarmac.c | 6 ++++--
drivers/atm/nicstarmac.h | 13 -------------
3 files changed, 4 insertions(+), 16 deletions(-)
--- linux-2.6.11-rc1-mm2-full/drivers/atm/nicstarmac.h 2005-01-20 07:44:04.000000000 +0100
+++ /dev/null 2004-11-25 03:16:25.000000000 +0100
@@ -1,13 +0,0 @@
-/******************************************************************************
- *
- * nicstarmac.h
- *
- * Header file for nicstarmac.c
- *
- ******************************************************************************/
-
-
-typedef void __iomem *virt_addr_t;
-
-void nicstar_init_eprom( virt_addr_t base );
-void nicstar_read_eprom( virt_addr_t, u_int8_t, u_int8_t *, u_int32_t);
--- linux-2.6.11-rc1-mm2-full/drivers/atm/nicstarmac.c.old 2005-01-21 13:23:05.000000000 +0100
+++ linux-2.6.11-rc1-mm2-full/drivers/atm/nicstarmac.c 2005-01-21 13:23:37.000000000 +0100
@@ -7,6 +7,8 @@
* Read this ForeRunner's MAC address from eprom/eeprom
*/
+typedef void __iomem *virt_addr_t;
+
#define CYCLE_DELAY 5
/* This was the original definition
@@ -213,7 +215,7 @@
}
-void
+static void
nicstar_init_eprom( virt_addr_t base )
{
u_int32_t val;
@@ -246,7 +248,7 @@
* above.
*/
-void
+static void
nicstar_read_eprom(
virt_addr_t base,
u_int8_t prom_offset,
--- linux-2.6.11-rc1-mm2-full/drivers/atm/nicstar.c.old 2005-01-21 13:26:41.000000000 +0100
+++ linux-2.6.11-rc1-mm2-full/drivers/atm/nicstar.c 2005-01-21 13:26:50.000000000 +0100
@@ -54,7 +54,6 @@
#include <asm/uaccess.h>
#include <asm/atomic.h>
#include "nicstar.h"
-#include "nicstarmac.h"
#ifdef CONFIG_ATM_NICSTAR_USE_SUNI
#include "suni.h"
#endif /* CONFIG_ATM_NICSTAR_USE_SUNI */
reply other threads:[~2005-01-21 12:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050121124218.GL3209@stusta.de \
--to=bunk@stusta.de \
--cc=chas@cmf.nrl.navy.mil \
--cc=jgarzik@pobox.com \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox