From: Kevin Corry <kevcorry@us.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: Benjamin LaHaise <bcrl@kvack.org>,
Alasdair G Kergon <agk@redhat.com>, Andrew Morton <akpm@osdl.org>
Subject: Re: device-mapper: fix TB stripe data corruption
Date: Fri, 21 Jan 2005 15:12:45 -0600 [thread overview]
Message-ID: <200501211512.45524.kevcorry@us.ibm.com> (raw)
In-Reply-To: <20050121203354.GC2265@kvack.org>
On Friday 21 January 2005 2:33 pm, Benjamin LaHaise wrote:
> On Fri, Jan 21, 2005 at 06:12:03PM +0000, Alasdair G Kergon wrote:
> > Missing cast thought to cause data corruption on devices with stripes >
> > ~1TB.
>
> Why not make chunk a sector_t?
We have to take a mod of the chunk value and the number of stripes (which can
be a non-power-of-2, so a shift won't work). It's been my understanding that
you couldn't mod a 64-bit value with a 32-bit value in the kernel. Just to be
sure, I've changed "chunk" to a sector_t and recompiled, and get the
following error:
MODPOST
*** Warning: "__udivdi3" [drivers/md/dm-mod.ko] undefined!
*** Warning: "__umoddi3" [drivers/md/dm-mod.ko] undefined!
--
Kevin Corry
kevcorry@us.ibm.com
http://evms.sourceforge.net/
next prev parent reply other threads:[~2005-01-21 21:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-21 18:12 device-mapper: fix TB stripe data corruption Alasdair G Kergon
2005-01-21 20:33 ` Benjamin LaHaise
2005-01-21 21:12 ` Kevin Corry [this message]
2005-01-21 21:20 ` Roland Dreier
2005-01-21 21:57 ` Kevin Corry
2005-01-22 22:35 ` Alasdair G Kergon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200501211512.45524.kevcorry@us.ibm.com \
--to=kevcorry@us.ibm.com \
--cc=agk@redhat.com \
--cc=akpm@osdl.org \
--cc=bcrl@kvack.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox