From: Andi Kleen <ak@suse.de>
To: Anton Blanchard <anton@samba.org>
Cc: Andi Kleen <ak@suse.de>, Matthew Wilcox <matthew@wil.cx>,
akpm@osdl.org, paulus@samba.org, tony.luck@intel.com,
ralf@linux-mips.org, schwidefsky@de.ibm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Problems disabling SYSCTL
Date: Mon, 24 Jan 2005 17:00:53 +0100 [thread overview]
Message-ID: <20050124160053.GB29950@wotan.suse.de> (raw)
In-Reply-To: <20050124135001.GC27258@krispykreme.ozlabs.ibm.com>
On Tue, Jan 25, 2005 at 12:50:01AM +1100, Anton Blanchard wrote:
>
> > > Is there any reason to not move the sys32_sysctl code to kernel/sysctl.c?
> >
> > iirc it relies on a unified address space (= user pointers still
> > work in KERNEL_DS)
>
> Yeah the sys32_sysctl code is pretty awful, perhaps we could do a better
> job now we have compat_alloc_userspace.
It also mishandles array of longs.
But seriously I wouldn't bother - the syscall interface is deprecated anyways
and has been for a long time. The only sysctl that needs to be handled
is (CTL_KERN,KERN_VERSION) [used by glibc], the others are not needed
and I hoep to eventually remove them even natively.
-Andi
P.S.: Andrew I just discovered you removed the printk code for this.
That's not good, how are users supposed to know it's deprecated?
next prev parent reply other threads:[~2005-01-24 16:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-23 5:01 [PATCH] Problems disabling SYSCTL Anton Blanchard
2005-01-23 14:35 ` Matthew Wilcox
2005-01-23 19:17 ` Andi Kleen
2005-01-24 13:50 ` Anton Blanchard
2005-01-24 16:00 ` Andi Kleen [this message]
2005-01-24 16:14 ` Matthew Wilcox
2005-01-24 16:21 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050124160053.GB29950@wotan.suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=anton@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
--cc=schwidefsky@de.ibm.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox