From: Greg KH <greg@kroah.com>
To: Jirka Kosina <jikos@jikos.cz>
Cc: Patrick Mochel <mochel@osdl.org>,
Linus Torvalds <torvalds@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix bad locking in drivers/base/driver.c
Date: Mon, 24 Jan 2005 21:56:51 -0800 [thread overview]
Message-ID: <20050125055651.GA1987@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0501241921310.5857@twin.jikos.cz>
On Mon, Jan 24, 2005 at 07:25:19PM +0100, Jirka Kosina wrote:
> Hi,
>
> there has been (for quite some time) a bug in function driver_unregister()
> - the lock/unlock sequence is protecting nothing and the actual
> bus_remove_driver() is called outside critical section.
>
> Please apply.
No, please read the comment in the code about why this is the way it is.
The code is correct as is.
Also, please CC the driver core maintainer next time for patches like
this so I don't miss them when they go by.
thanks,
greg k-h
next prev parent reply other threads:[~2005-01-25 5:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-24 18:25 [PATCH] fix bad locking in drivers/base/driver.c Jirka Kosina
2005-01-24 19:00 ` Chris Wright
2005-01-25 5:56 ` Greg KH [this message]
2005-01-25 7:32 ` Mike Waychison
2005-01-25 13:49 ` Bill Davidsen
2005-01-25 16:10 ` Mike Waychison
2005-01-25 16:27 ` Linus Torvalds
2005-01-25 19:19 ` Greg KH
2005-01-25 19:38 ` Thomas Gleixner
2005-02-02 23:35 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050125055651.GA1987@kroah.com \
--to=greg@kroah.com \
--cc=jikos@jikos.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@osdl.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox