From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, iss_storagedev@hp.com
Subject: [2.6 patch] drivers/block/cpqarray.c: small cleanups
Date: Tue, 25 Jan 2005 12:28:05 +0100 [thread overview]
Message-ID: <20050125112805.GI30909@stusta.de> (raw)
This patch contains the following cleanups:
- make cpqarray_pci_device_id static
- merge cpqarray_init_step2 into cpqarray_init and make it static
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/block/cpqarray.c | 13 ++-----------
1 files changed, 2 insertions(+), 11 deletions(-)
This patch was already sent on:
- 29 Nov 2004
--- linux-2.6.10-rc1-mm3-full/drivers/block/cpqarray.c.old 2004-11-06 19:51:42.000000000 +0100
+++ linux-2.6.10-rc1-mm3-full/drivers/block/cpqarray.c 2004-11-06 19:53:16.000000000 +0100
@@ -97,7 +97,7 @@
};
/* define the PCI info for the PCI cards this driver can control */
-const struct pci_device_id cpqarray_pci_device_id[] =
+static const struct pci_device_id cpqarray_pci_device_id[] =
{
{ PCI_VENDOR_ID_DEC, PCI_DEVICE_ID_COMPAQ_42XX,
0x0E11, 0x4058, 0, 0, 0}, /* SA431 */
@@ -135,7 +135,6 @@
/* Debug Extra Paranoid... */
#define DBGPX(s) do { } while(0)
-int cpqarray_init_step2(void);
static int cpqarray_pci_init(ctlr_info_t *c, struct pci_dev *pdev);
static void __iomem *remap_pci_mem(ulong base, ulong size);
static int cpqarray_eisa_detect(void);
@@ -312,14 +311,6 @@
module_param_array(eisa, int, NULL, 0);
-/* This is a bit of a hack,
- * necessary to support both eisa and pci
- */
-int __init cpqarray_init(void)
-{
- return (cpqarray_init_step2());
-}
-
static void release_io_mem(ctlr_info_t *c)
{
/* if IO mem was not protected do nothing */
@@ -560,7 +551,7 @@
* This is it. Find all the controllers and register them.
* returns the number of block devices registered.
*/
-int __init cpqarray_init_step2(void)
+static int __init cpqarray_init(void)
{
int num_cntlrs_reg = 0;
int i;
next reply other threads:[~2005-01-25 11:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-25 11:28 Adrian Bunk [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-01-25 14:51 [2.6 patch] drivers/block/cpqarray.c: small cleanups Miller, Mike (OS Dev)
2004-11-24 23:10 [2.6 patch] drivers/block/: some cleanups Adrian Bunk
2004-11-25 10:12 ` Christoph Hellwig
2004-11-29 12:26 ` [2.6 patch] drivers/block/cpqarray.c: small cleanups Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050125112805.GI30909@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=iss_storagedev@hp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox