public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Shawn Starr <shawn.starr@rogers.com>
Cc: Aurelien Jarno <aurelien@aurel32.net>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.11-rc2] I2C: lm80 driver improvement (From Aurelien) - Resubmit
Date: Wed, 26 Jan 2005 08:42:12 -0800	[thread overview]
Message-ID: <20050126164212.GA3366@kroah.com> (raw)
In-Reply-To: <200501260257.35605.shawn.starr@rogers.com>

On Wed, Jan 26, 2005 at 02:57:35AM -0500, Shawn Starr wrote:
>  static inline unsigned char FAN_TO_REG(unsigned rpm, unsigned div)
>  {
> -	if (rpm == 0)
> +	if (rpm <= 0)

As was pointed out, this doesn't make any sense.

Care to redo the patch?

thanks,

greg k-h

  reply	other threads:[~2005-01-26 16:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-26  7:49 [PATCH 2.6.11-rc2] I2C: lm80 driver improvement (From Aurelien) Shawn Starr
2005-01-26  7:57 ` [PATCH 2.6.11-rc2] I2C: lm80 driver improvement (From Aurelien) - Resubmit Shawn Starr
2005-01-26 16:42   ` Greg KH [this message]
2005-01-26 17:31     ` [PATCH 2.6.11-rc2] I2C: lm80 driver improvement (From Aurelien) - Resubmit #2 Shawn Starr
2005-01-27  9:03       ` Greg KH
2005-01-27 16:56         ` [PATCH 2.6.11-rc2] I2C: lm80 driver improvement - Shawn Starr
2005-01-29 23:25           ` Greg KH
2005-01-30  2:08             ` [PATCH 2.6.11-rc2] I2C: lm80 driver improvement - again Shawn Starr
2005-02-01  8:12               ` Greg KH
2005-01-26 17:54     ` [PATCH 2.6.11-rc2] I2C: lm80 driver improvement (From Aurelien) - Resubmit Aurélien Jarno
2005-01-26 14:05 ` [PATCH 2.6.11-rc2] I2C: lm80 driver improvement (From Aurelien) Sytse Wielinga
2005-01-26 14:20   ` Sytse Wielinga

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050126164212.GA3366@kroah.com \
    --to=greg@kroah.com \
    --cc=aurelien@aurel32.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shawn.starr@rogers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox