From: William Lee Irwin III <wli@holomorphy.com>
To: Rik van Riel <riel@redhat.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org,
James Antill <james.antill@redhat.com>,
Bryn Reeves <breeves@redhat.com>
Subject: Re: don't let mmap allocate down to zero
Date: Wed, 26 Jan 2005 09:25:38 -0800 [thread overview]
Message-ID: <20050126172538.GN10843@holomorphy.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0501261116140.5677@chimarrao.boston.redhat.com>
On Wed, Jan 26, 2005 at 11:18:08AM -0500, Rik van Riel wrote:
> With some programs the 2.6 kernel can end up allocating memory
> at address zero, for a non-MAP_FIXED mmap call! This causes
> problems with some programs and is generally rude to do. This
> simple patch fixes the problem in my tests.
> Make sure that we don't allocate memory all the way down to zero,
> so the NULL pointer never gets covered up with anonymous memory
> and we don't end up violating the C standard.
> Signed-off-by: Rik van Riel <riel@redhat.com>
SHLIB_BASE does not appear to be present in 2.6.9; perhaps something
else is going on.
I think we are better off:
(a) checking for hitting zero explicitly as opposed to
enforcing a randomly-chosen lower limit for addresses
(b) enforcing vma allocation above FIRST_USER_PGD_NR*PGDIR_SIZE,
to which SHLIB_BASE bears no relation.
-- wli
next prev parent reply other threads:[~2005-01-26 23:13 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-26 16:18 don't let mmap allocate down to zero Rik van Riel
2005-01-26 16:38 ` linux-os
2005-01-26 17:05 ` Sytse Wielinga
2005-01-26 17:34 ` Chris Friesen
2005-01-26 17:57 ` Bryn Reeves
2005-01-26 18:37 ` linux-os
2005-01-26 18:54 ` Rik van Riel
2005-01-26 19:09 ` linux-os
2005-01-26 19:13 ` Chris Friesen
2005-01-26 19:08 ` Chris Friesen
2005-01-26 18:10 ` Olivier Galibert
2005-01-26 18:20 ` linux-os
2005-01-26 18:31 ` Olivier Galibert
2005-01-26 18:39 ` linux-os
2005-01-26 19:41 ` Arjan van de Ven
2005-01-26 20:26 ` Andy Isaacson
2005-01-26 20:42 ` Rik van Riel
2005-01-26 22:12 ` Kyle Moffett
2005-01-26 23:31 ` Brian Gerst
2005-01-26 17:25 ` William Lee Irwin III [this message]
2005-01-27 5:09 ` William Lee Irwin III
2005-01-27 5:18 ` Dave Jones
2005-01-27 5:28 ` William Lee Irwin III
2005-01-27 9:29 ` Mikael Pettersson
2005-01-27 12:52 ` William Lee Irwin III
2005-01-27 14:25 ` Russell King
2005-01-27 15:12 ` William Lee Irwin III
2005-01-27 19:22 ` Rik van Riel
2005-01-27 20:44 ` William Lee Irwin III
2005-01-27 20:58 ` Rik van Riel
2005-01-27 21:13 ` William Lee Irwin III
2005-01-27 21:28 ` Rik van Riel
2005-01-28 5:30 ` William Lee Irwin III
2005-01-28 13:01 ` Rik van Riel
2005-01-28 14:14 ` Hugh Dickins
2005-01-28 14:26 ` William Lee Irwin III
2005-01-28 15:41 ` Rik van Riel
2005-01-28 15:53 ` Hugh Dickins
2005-01-27 21:58 ` linux-os
2005-01-27 14:26 ` Mikael Pettersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050126172538.GN10843@holomorphy.com \
--to=wli@holomorphy.com \
--cc=akpm@osdl.org \
--cc=breeves@redhat.com \
--cc=james.antill@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox