public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Olivier Galibert <galibert@pobox.com>
To: linux-os <linux-os@analogic.com>
Cc: Rik van Riel <riel@redhat.com>, Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org,
	James Antill <james.antill@redhat.com>,
	Bryn Reeves <breeves@redhat.com>
Subject: Re: don't let mmap allocate down to zero
Date: Wed, 26 Jan 2005 19:31:21 +0100	[thread overview]
Message-ID: <20050126183121.GA93329@dspnet.fr.eu.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0501261315220.18301@chaos.analogic.com>

On Wed, Jan 26, 2005 at 01:20:53PM -0500, linux-os wrote:
> On Wed, 26 Jan 2005, Olivier Galibert wrote:
> >Given that the man page itself says that unless you're using MAP_FIXED
> >start is only a hint and you should use 0 if you don't care things can
> >get real annoying real fast.  Imagine if you want to mmap a <4K file
> >and mmap then returns 0, i.e. NULL, as the mapping address as you
> >asked.  It's illegal from the point of view of susv3[1] and it's real
> >annoying in a C/C++ program.
> 
> mmap() can (will) return 0 if you use 0 as the hint and use MAP_FIXED
> at 0. That's the reason why one does NOT check for NULL with mmap() but
> for MAP_FAILED (which on this system is (void *)-1.

All the paragraph was under an obvious "when you do not use MAP_FIXED"
precondition.  The patch is not supposed to change anything to the
MAP_FIXED case.  Malloc does not use MAP_FIXED.  Usual file mmaping
as an alternative to read() does not use MAP_FIXED.

  OG.

  reply	other threads:[~2005-01-26 23:43 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-26 16:18 don't let mmap allocate down to zero Rik van Riel
2005-01-26 16:38 ` linux-os
2005-01-26 17:05   ` Sytse Wielinga
2005-01-26 17:34   ` Chris Friesen
2005-01-26 17:57     ` Bryn Reeves
2005-01-26 18:37       ` linux-os
2005-01-26 18:54         ` Rik van Riel
2005-01-26 19:09           ` linux-os
2005-01-26 19:13         ` Chris Friesen
2005-01-26 19:08       ` Chris Friesen
2005-01-26 18:10   ` Olivier Galibert
2005-01-26 18:20     ` linux-os
2005-01-26 18:31       ` Olivier Galibert [this message]
2005-01-26 18:39         ` linux-os
2005-01-26 19:41   ` Arjan van de Ven
2005-01-26 20:26   ` Andy Isaacson
2005-01-26 20:42     ` Rik van Riel
2005-01-26 22:12   ` Kyle Moffett
2005-01-26 23:31   ` Brian Gerst
2005-01-26 17:25 ` William Lee Irwin III
2005-01-27  5:09   ` William Lee Irwin III
2005-01-27  5:18     ` Dave Jones
2005-01-27  5:28       ` William Lee Irwin III
2005-01-27  9:29     ` Mikael Pettersson
2005-01-27 12:52       ` William Lee Irwin III
2005-01-27 14:25         ` Russell King
2005-01-27 15:12           ` William Lee Irwin III
2005-01-27 19:22             ` Rik van Riel
2005-01-27 20:44               ` William Lee Irwin III
2005-01-27 20:58                 ` Rik van Riel
2005-01-27 21:13                   ` William Lee Irwin III
2005-01-27 21:28                     ` Rik van Riel
2005-01-28  5:30                       ` William Lee Irwin III
2005-01-28 13:01                         ` Rik van Riel
2005-01-28 14:14                           ` Hugh Dickins
2005-01-28 14:26                             ` William Lee Irwin III
2005-01-28 15:41                             ` Rik van Riel
2005-01-28 15:53                               ` Hugh Dickins
2005-01-27 21:58                     ` linux-os
2005-01-27 14:26         ` Mikael Pettersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050126183121.GA93329@dspnet.fr.eu.org \
    --to=galibert@pobox.com \
    --cc=akpm@osdl.org \
    --cc=breeves@redhat.com \
    --cc=james.antill@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-os@analogic.com \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox