public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Olaf Hering <olh@suse.de>
To: linux-kernel@vger.kernel.org, Hai-Pao Fan <haipao@mvista.com>
Cc: Andrew Morton <akpm@osdl.org>
Subject: drivers/char/ite_gpio.c, GPIO_MINOR missing
Date: Thu, 27 Jan 2005 14:17:14 +0100	[thread overview]
Message-ID: <20050127131714.GA23935@suse.de> (raw)


What is the minor number for this driver?
Its not referenced in the makefile, it has no official minor number.
2.4 has MISC_DYNAMIC_MINOR. Should 2.6 use the same?

2.6 driver came already broken.
http://linux.bkbits.net:8080/linux-2.5/gnupatch@3c603dd1pp70eWnkCkTN6Yif9vw14Q

--- ../linux-2.6.11-rc2/drivers/char/ite_gpio.c	2005-01-22 02:48:28.000000000 +0100
+++ ./drivers/char/ite_gpio.c	2005-01-27 14:12:08.418388476 +0100
@@ -370,10 +370,9 @@ static struct file_operations ite_gpio_f
 	.release	= ite_gpio_release,
 };
 
-/* GPIO_MINOR in include/linux/miscdevice.h */
 static struct miscdevice ite_gpio_miscdev =
 {
-	GPIO_MINOR,
+	MISC_DYNAMIC_MINOR,
 	"ite_gpio",
 	&ite_gpio_fops
 };

                 reply	other threads:[~2005-01-27 13:17 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050127131714.GA23935@suse.de \
    --to=olh@suse.de \
    --cc=akpm@osdl.org \
    --cc=haipao@mvista.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox