From: Olaf Hering <olh@suse.de>
To: linux-kernel@vger.kernel.org, Stelian Pop <stelian@popies.net>
Cc: Andrew Morton <akpm@osdl.org>
Subject: [PATCH] use misc dynamic minor for sonypi driver
Date: Thu, 27 Jan 2005 14:46:40 +0100 [thread overview]
Message-ID: <20050127134640.GA25549@suse.de> (raw)
Whats the reason for using -1 as minor number?
No idea if that works well, it probably does.
Maybe add a comment if -1 is supposed to work.
--- ../linux-2.6.11-rc2/drivers/char/sonypi.c 2005-01-22 02:48:34.000000000 +0100
+++ ./drivers/char/sonypi.c 2005-01-27 14:40:47.873882682 +0100
@@ -649,7 +649,7 @@
};
struct miscdevice sonypi_misc_device = {
- .minor = -1,
+ .minor = MISC_DYNAMIC_MINOR,
.name = "sonypi",
.fops = &sonypi_misc_fops,
};
next reply other threads:[~2005-01-27 13:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-27 13:46 Olaf Hering [this message]
2005-01-27 14:02 ` [PATCH] use misc dynamic minor for sonypi driver Stelian Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050127134640.GA25549@suse.de \
--to=olh@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stelian@popies.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox