public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kay Sievers <kay.sievers@vrfy.org>
To: linux-kernel@vger.kernel.org
Cc: Greg KH <greg@kroah.com>
Subject: Re: [PATCH] sysfs: export the vfs release call of binary attribute
Date: Thu, 27 Jan 2005 21:34:10 +0100	[thread overview]
Message-ID: <20050127203410.GA5022@vrfy.org> (raw)
In-Reply-To: <20050127201923.GA4968@vrfy.org>

On Thu, Jan 27, 2005 at 09:19:23PM +0100, Kay Sievers wrote:
> Initialize the allocated bin_attribute structure, otherwise unused fields
> are pointing to random places.

Sorry, wrong place for the inititalization.

Signed-off-by: Kay Sievers <kay.sievers@vrfy.org>

===== drivers/pci/pci-sysfs.c 1.16 vs edited =====
--- 1.16/drivers/pci/pci-sysfs.c	2005-01-06 21:30:29 +01:00
+++ edited/drivers/pci/pci-sysfs.c	2005-01-27 21:31:09 +01:00
@@ -436,6 +436,7 @@ int pci_create_sysfs_dev_files (struct p
 		
 		rom_attr = kmalloc(sizeof(*rom_attr), GFP_ATOMIC);
 		if (rom_attr) {
+			memset(rom_attr, 0x00, sizeof(*rom_attr));
 			pdev->rom_attr = rom_attr;
 			rom_attr->size = pci_resource_len(pdev, PCI_ROM_RESOURCE);
 			rom_attr->attr.name = "rom";


  reply	other threads:[~2005-01-27 20:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-27 20:19 [PATCH] sysfs: export the vfs release call of binary attribute Kay Sievers
2005-01-27 20:34 ` Kay Sievers [this message]
2005-02-01  0:15   ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2005-01-27 10:07 Kay Sievers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050127203410.GA5022@vrfy.org \
    --to=kay.sievers@vrfy.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox