public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: William Lee Irwin III <wli@holomorphy.com>
To: Rik van Riel <riel@redhat.com>
Cc: Russell King <rmk+lkml@arm.linux.org.uk>,
	Mikael Pettersson <mikpe@csd.uu.se>,
	Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org,
	James Antill <james.antill@redhat.com>,
	Bryn Reeves <breeves@redhat.com>
Subject: Re: don't let mmap allocate down to zero
Date: Thu, 27 Jan 2005 21:30:36 -0800	[thread overview]
Message-ID: <20050128053036.GO10843@holomorphy.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0501271626460.13927@chimarrao.boston.redhat.com>

On Thu, 27 Jan 2005, William Lee Irwin III wrote:
>> The intention was to disallow vmas starting at 0 categorically. i.e. it
>> is very intentional to deny the MREMAP_FIXED to 0 case of mremap().
>> It was also the intention to deny the MAP_FIXED to 0 case of mmap(),
>> though I didn't actually sweep that much (if at all).

On Thu, Jan 27, 2005 at 04:28:19PM -0500, Rik van Riel wrote:
> We can't do that, look at line 944 of fs/binfmt_elf.c:
>         if (current->personality & MMAP_PAGE_ZERO) {
>                 /* Why this, you ask???  Well SVr4 maps page 0 as read-only,
>                    and some applications "depend" upon this behavior.
>                    Since we do not have the power to recompile these, we
>                    emulate the SVr4 behavior.  Sigh.  */
>                 down_write(&current->mm->mmap_sem);
>                 error = do_mmap(NULL, 0, PAGE_SIZE, PROT_READ | PROT_EXEC,
>                                 MAP_FIXED | MAP_PRIVATE, 0);
>                 up_write(&current->mm->mmap_sem);
>         }

You seem to be on about something else, e.g. only forbidding the vma
allocator to return a vma starting at 0 when not specifically requested.
In that case vma->vm_start < mm->brk and similar are all fine.


-- wli

  reply	other threads:[~2005-01-28  5:30 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-26 16:18 don't let mmap allocate down to zero Rik van Riel
2005-01-26 16:38 ` linux-os
2005-01-26 17:05   ` Sytse Wielinga
2005-01-26 17:34   ` Chris Friesen
2005-01-26 17:57     ` Bryn Reeves
2005-01-26 18:37       ` linux-os
2005-01-26 18:54         ` Rik van Riel
2005-01-26 19:09           ` linux-os
2005-01-26 19:13         ` Chris Friesen
2005-01-26 19:08       ` Chris Friesen
2005-01-26 18:10   ` Olivier Galibert
2005-01-26 18:20     ` linux-os
2005-01-26 18:31       ` Olivier Galibert
2005-01-26 18:39         ` linux-os
2005-01-26 19:41   ` Arjan van de Ven
2005-01-26 20:26   ` Andy Isaacson
2005-01-26 20:42     ` Rik van Riel
2005-01-26 22:12   ` Kyle Moffett
2005-01-26 23:31   ` Brian Gerst
2005-01-26 17:25 ` William Lee Irwin III
2005-01-27  5:09   ` William Lee Irwin III
2005-01-27  5:18     ` Dave Jones
2005-01-27  5:28       ` William Lee Irwin III
2005-01-27  9:29     ` Mikael Pettersson
2005-01-27 12:52       ` William Lee Irwin III
2005-01-27 14:25         ` Russell King
2005-01-27 15:12           ` William Lee Irwin III
2005-01-27 19:22             ` Rik van Riel
2005-01-27 20:44               ` William Lee Irwin III
2005-01-27 20:58                 ` Rik van Riel
2005-01-27 21:13                   ` William Lee Irwin III
2005-01-27 21:28                     ` Rik van Riel
2005-01-28  5:30                       ` William Lee Irwin III [this message]
2005-01-28 13:01                         ` Rik van Riel
2005-01-28 14:14                           ` Hugh Dickins
2005-01-28 14:26                             ` William Lee Irwin III
2005-01-28 15:41                             ` Rik van Riel
2005-01-28 15:53                               ` Hugh Dickins
2005-01-27 21:58                     ` linux-os
2005-01-27 14:26         ` Mikael Pettersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050128053036.GO10843@holomorphy.com \
    --to=wli@holomorphy.com \
    --cc=akpm@osdl.org \
    --cc=breeves@redhat.com \
    --cc=james.antill@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikpe@csd.uu.se \
    --cc=riel@redhat.com \
    --cc=rmk+lkml@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox