From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Martin Zwickel <martin.zwickel@technotrend.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
hugang@soulinfo.com, Pavel Machek <pavel@suse.cz>,
Nigel Cunningham <ncunningham@linuxmail.org>
Subject: Re: [RFC][PATCH] swsusp: do not use higher order memory allocations on suspend
Date: Fri, 28 Jan 2005 18:52:43 +0100 [thread overview]
Message-ID: <200501281852.43689.rjw@sisk.pl> (raw)
In-Reply-To: <20050128150756.1d6976cb@phoebee>
On Friday, 28 of January 2005 15:07, Martin Zwickel wrote:
> > @@ -373,15 +377,22 @@
> >
> > static int write_pagedir(void)
> > {
> > - unsigned long addr = (unsigned long)pagedir_nosave;
> > int error = 0;
> > - int n = SUSPEND_PD_PAGES(nr_copy_pages);
> > - int i;
> > + unsigned n = 0;
> > + struct pbe * pbe;
> > +
> > + printk( "Writing pagedir ...");
> >
> > +
> > + pr_debug("\b\b\bdone (%u pages)\n", n);
>
> Just cosmetic:
> Why do you use pr_debug here instead of printk like you did above?
By mistake. :-) Thanks!
Greets,
RJW
--
- Would you tell me, please, which way I ought to go from here?
- That depends a good deal on where you want to get to.
-- Lewis Carroll "Alice's Adventures in Wonderland"
next prev parent reply other threads:[~2005-01-28 17:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-28 13:54 [RFC][PATCH] swsusp: do not use higher order memory allocations on suspend Rafael J. Wysocki
2005-01-28 14:07 ` Martin Zwickel
2005-01-28 17:52 ` Rafael J. Wysocki [this message]
2005-01-28 17:24 ` Pavel Machek
2005-01-28 18:31 ` Rafael J. Wysocki
[not found] ` <200501300052.55545.rjw@sisk.pl>
[not found] ` <20050131130631.GF6279@elf.ucw.cz>
[not found] ` <200501311510.12979.rjw@sisk.pl>
2005-01-31 18:20 ` Pavel Machek
2005-01-31 18:52 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200501281852.43689.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=hugang@soulinfo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.zwickel@technotrend.de \
--cc=ncunningham@linuxmail.org \
--cc=pavel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox