From: Adrian Bunk <bunk@stusta.de>
To: Sam Hopkins <sah@coraid.com>
Cc: linux-kernel@vger.kernel.org
Subject: [2.6 patch] drivers/block/aoe/aoechr.c cleanups
Date: Sat, 29 Jan 2005 14:35:20 +0100 [thread overview]
Message-ID: <20050129133520.GV28047@stusta.de> (raw)
This patch contains the following cleanups:
- make the needlessly global struct aoe_fops static
- #if 0 the unused global function aoechr_hdump
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/block/aoe/aoechr.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletion(-)
--- linux-2.6.11-rc2-mm1-full/drivers/block/aoe/aoechr.c.old 2005-01-29 13:43:34.000000000 +0100
+++ linux-2.6.11-rc2-mm1-full/drivers/block/aoe/aoechr.c 2005-01-29 13:44:16.000000000 +0100
@@ -99,6 +99,8 @@
up(&emsgs_sema);
}
+#if 0
+
#define PERLINE 16
void
aoechr_hdump(char *buf, int n)
@@ -134,6 +136,8 @@
kfree(fbuf);
}
+#endif /* 0 */
+
static ssize_t
aoechr_write(struct file *filp, const char __user *buf, size_t cnt, loff_t *offp)
{
@@ -233,7 +237,7 @@
}
}
-struct file_operations aoe_fops = {
+static struct file_operations aoe_fops = {
.write = aoechr_write,
.read = aoechr_read,
.open = aoechr_open,
next reply other threads:[~2005-01-29 13:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-29 13:35 Adrian Bunk [this message]
2005-01-31 14:34 ` [2.6 patch] drivers/block/aoe/aoechr.c cleanups Ed L Cashin
2005-02-01 7:54 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050129133520.GV28047@stusta.de \
--to=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=sah@coraid.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox