From: Adrian Bunk <bunk@stusta.de>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] drivers/cdrom/isp16.c: small cleanups
Date: Sun, 30 Jan 2005 00:46:24 +0100 [thread overview]
Message-ID: <20050129234624.GC3185@stusta.de> (raw)
In-Reply-To: <58cb370e05012909513cc96b17@mail.gmail.com>
On Sat, Jan 29, 2005 at 06:51:25PM +0100, Bartlomiej Zolnierkiewicz wrote:
> Hi,
>
> On Sat, 29 Jan 2005 18:11:08 +0100, Adrian Bunk <bunk@stusta.de> wrote:
> > This patch makes the needlessly global function isp16_init static.
> >
> > As a result, it turned out that both this function and some other code
> > are only required #ifdef MODULE.
>
> Your patch is correct but it is wrong. ;)
>
> #ifdefs around isp16_init() need to be removed as
> otherwise this driver is not initialized in built-in case.
It's somehow initialized via isp16_setup.
> Bartlomiej
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2005-01-29 23:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-29 17:11 [2.6 patch] drivers/cdrom/isp16.c: small cleanups Adrian Bunk
2005-01-29 17:51 ` Bartlomiej Zolnierkiewicz
2005-01-29 23:46 ` Adrian Bunk [this message]
2005-01-29 23:54 ` Bartlomiej Zolnierkiewicz
2005-01-30 9:02 ` [FIX] " Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050129234624.GC3185@stusta.de \
--to=bunk@stusta.de \
--cc=bzolnier@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox