From: Arnd Bergmann <arnd@arndb.de>
To: blaisorblade@yahoo.it
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, dhowells@redhat.com
Subject: Re: [patch 1/1] fix syscallN() macro errno value checking for i386
Date: Sun, 30 Jan 2005 18:00:22 +0100 [thread overview]
Message-ID: <200501301800.22706.arnd@arndb.de> (raw)
In-Reply-To: <20050129010145.1C42F8C9E4@zion>
[-- Attachment #1: Type: text/plain, Size: 852 bytes --]
On Sünnavend 29 Januar 2005 02:01, blaisorblade@yahoo.it wrote:
>
> From: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
> Cc: David Howells <dhowells@redhat.com>
>
> The errno values which are visible for userspace are actually in the range
> -1 - -129, not until -128 (): this value was added:
>
> #define EKEYREJECTED 129 /* Key was rejected by service */
>
> And this would break ucLibc (for what I heard).
>
> This is just a quick-fix, because putting a macro inside errno.h instead of
> having it copied in two places would be probably nicer.
Yes. Note that your patch only fixes the bug on i386. The code has been
copied to many other architectures, and some of them have been updated
less recently and are checking for values lower than 128. There should
really be a way to keep them all in sync.
Arnd <><
[-- Attachment #2: signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2005-01-30 17:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-29 1:01 [patch 1/1] fix syscallN() macro errno value checking for i386 blaisorblade
2005-01-30 17:00 ` Arnd Bergmann [this message]
2005-01-30 18:30 ` jerome lacoste
2005-02-04 0:36 ` H. Peter Anvin
2005-03-05 17:59 ` Blaisorblade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200501301800.22706.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@osdl.org \
--cc=blaisorblade@yahoo.it \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox