Re: [PATCH 0/16] New set of input patches

Vojtech Pavlik
2005-01-27T16:15:21Z

On Thu, Jan 27, 2005 at 09:04:06AM -0500, Dmitry Torokhov wrote:
> Vojtech,
>
> I have dropped the patches that have already been applied and
> re-diffed the remaining patches. I have also merged Adrian's global ->
> static cleanup and 2 patches from Prarit Bhargava (one re: releasing
> resources acquired by i8042_platform_init if controller initialization
> fails and the other is re: making educating guess whether controller
> is absent or really times out).
>
> There also was couple of additional changes - serio drivers now use
> MODULE_DEVICE_TABLE to export information about the ports they can
> possible work with; serio core exports port's type, protocol, id and
> "extra" data as sysfs attributes and there is hotplug function to
> signal userspace about new port. This all was done so that hotplug can
> automatically load appropriate driver (for example psmouse) when a new
> port is detected. I have patches for module-init-tools and hotplug
> scripts that I will sent to Greg and Rusty as soon as you take the
> pathes (if you will).
>
> I think that the very first path ("while true; do xset led 3; xset
> -led 3; done" makes keyboard miss release events and makes it
> unusable) should go in 2.6.11 so please do:
>
> bk pull bk://dtor.bkbits.net/for-2.6.11

Pulled, pushed into my tree. I verified the patch, and it is indeed
correct. Before we get an ACK for a command we sent, we still may
receive normal data. After we got the ACK we know for sure that no more
regular data will come, and can expect the command response.

> That repository has only this change. The rest of the patches are in
> my usual repository:
>
> bk pull bk://dtor.bkbits.net/input
>
> I am not sending the patches separately as they had been posted to the
> lists couple of times already.

OK. I'll go through them, and apply as appropriate. I still need to wrap
my mind around the start() and stop() methods and see the necessity. I
still think a variable in the serio struct, only accessed by the serio.c
core driver itself (and never by the port driver) that'd cause all
serio_interrupt() calls to be ignored until set in the asynchronous port
registration would be well enough.

--
Vojtech Pavlik
SuSE Labs, SuSE CR