public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [RFC: 2.6 patch] unexport get_wchan
@ 2005-01-31 13:36 Adrian Bunk
  2005-01-31 14:04 ` Greg Banks
  0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2005-01-31 13:36 UTC (permalink / raw)
  To: linux-kernel

The only user of get_wchan I was able to find is the proc fs - and proc 
can't be built modular.

Is the patch below to remove the export of get_wchan correct or did I 
oversee something?

---

 arch/alpha/kernel/alpha_ksyms.c    |    2 --
 arch/arm/kernel/process.c          |    1 -
 arch/arm26/kernel/armksyms.c       |    2 --
 arch/frv/kernel/frv_ksyms.c        |    2 --
 arch/h8300/kernel/h8300_ksyms.c    |    2 --
 arch/i386/kernel/i386_ksyms.c      |    2 --
 arch/m68k/kernel/m68k_ksyms.c      |    1 -
 arch/m68knommu/kernel/m68k_ksyms.c |    2 --
 arch/mips/kernel/process.c         |    1 -
 arch/ppc/kernel/ppc_ksyms.c        |    1 -
 arch/ppc64/kernel/ppc_ksyms.c      |    1 -
 arch/x86_64/kernel/x8664_ksyms.c   |    2 --
 12 files changed, 19 deletions(-)

--- linux-2.6.11-rc2-mm2-full/arch/i386/kernel/i386_ksyms.c.old	2005-01-31 14:15:27.000000000 +0100
+++ linux-2.6.11-rc2-mm2-full/arch/i386/kernel/i386_ksyms.c	2005-01-31 14:15:37.000000000 +0100
@@ -159,8 +159,6 @@
 EXPORT_SYMBOL(screen_info);
 #endif
 
-EXPORT_SYMBOL(get_wchan);
-
 EXPORT_SYMBOL(rtc_lock);
 
 EXPORT_SYMBOL_GPL(set_nmi_callback);
--- linux-2.6.11-rc2-mm2-full/arch/arm/kernel/process.c.old	2005-01-31 14:15:46.000000000 +0100
+++ linux-2.6.11-rc2-mm2-full/arch/arm/kernel/process.c	2005-01-31 14:15:52.000000000 +0100
@@ -461,4 +461,3 @@
 	} while (count ++ < 16);
 	return 0;
 }
-EXPORT_SYMBOL(get_wchan);
--- linux-2.6.11-rc2-mm2-full/arch/ppc/kernel/ppc_ksyms.c.old	2005-01-31 14:15:59.000000000 +0100
+++ linux-2.6.11-rc2-mm2-full/arch/ppc/kernel/ppc_ksyms.c	2005-01-31 14:16:03.000000000 +0100
@@ -288,7 +288,6 @@
 EXPORT_SYMBOL(timer_interrupt);
 EXPORT_SYMBOL(irq_desc);
 EXPORT_SYMBOL(tb_ticks_per_jiffy);
-EXPORT_SYMBOL(get_wchan);
 EXPORT_SYMBOL(console_drivers);
 #ifdef CONFIG_XMON
 EXPORT_SYMBOL(xmon);
--- linux-2.6.11-rc2-mm2-full/arch/mips/kernel/process.c.old	2005-01-31 14:16:10.000000000 +0100
+++ linux-2.6.11-rc2-mm2-full/arch/mips/kernel/process.c	2005-01-31 14:16:29.000000000 +0100
@@ -361,4 +361,3 @@
 	return pc;
 }
 
-EXPORT_SYMBOL(get_wchan);
--- linux-2.6.11-rc2-mm2-full/arch/m68knommu/kernel/m68k_ksyms.c.old	2005-01-31 14:16:37.000000000 +0100
+++ linux-2.6.11-rc2-mm2-full/arch/m68knommu/kernel/m68k_ksyms.c	2005-01-31 14:16:40.000000000 +0100
@@ -60,8 +60,6 @@
 EXPORT_SYMBOL(__down_failed_trylock);
 EXPORT_SYMBOL(__up_wakeup);
 
-EXPORT_SYMBOL(get_wchan);
-
 /*
  * libgcc functions - functions that are used internally by the
  * compiler...  (prototypes are not correct though, but that
--- linux-2.6.11-rc2-mm2-full/arch/arm26/kernel/armksyms.c.old	2005-01-31 14:16:49.000000000 +0100
+++ linux-2.6.11-rc2-mm2-full/arch/arm26/kernel/armksyms.c	2005-01-31 14:16:52.000000000 +0100
@@ -213,8 +213,6 @@
 EXPORT_SYMBOL(sys_exit);
 EXPORT_SYMBOL(sys_wait4);
 
-EXPORT_SYMBOL(get_wchan);
-
 #ifdef CONFIG_PREEMPT
 EXPORT_SYMBOL(kernel_flag);
 #endif
--- linux-2.6.11-rc2-mm2-full/arch/m68k/kernel/m68k_ksyms.c.old	2005-01-31 14:17:00.000000000 +0100
+++ linux-2.6.11-rc2-mm2-full/arch/m68k/kernel/m68k_ksyms.c	2005-01-31 14:17:05.000000000 +0100
@@ -85,4 +85,3 @@
 EXPORT_SYMBOL(__down_failed_trylock);
 EXPORT_SYMBOL(__up_wakeup);
 
-EXPORT_SYMBOL(get_wchan);
--- linux-2.6.11-rc2-mm2-full/arch/alpha/kernel/alpha_ksyms.c.old	2005-01-31 14:17:12.000000000 +0100
+++ linux-2.6.11-rc2-mm2-full/arch/alpha/kernel/alpha_ksyms.c	2005-01-31 14:17:16.000000000 +0100
@@ -228,8 +228,6 @@
 EXPORT_SYMBOL(memset);
 EXPORT_SYMBOL(memchr);
 
-EXPORT_SYMBOL(get_wchan);
-
 #ifdef CONFIG_ALPHA_IRONGATE
 EXPORT_SYMBOL(irongate_ioremap);
 EXPORT_SYMBOL(irongate_iounmap);
--- linux-2.6.11-rc2-mm2-full/arch/ppc64/kernel/ppc_ksyms.c.old	2005-01-31 14:17:23.000000000 +0100
+++ linux-2.6.11-rc2-mm2-full/arch/ppc64/kernel/ppc_ksyms.c	2005-01-31 14:17:27.000000000 +0100
@@ -151,7 +151,6 @@
 
 EXPORT_SYMBOL(timer_interrupt);
 EXPORT_SYMBOL(irq_desc);
-EXPORT_SYMBOL(get_wchan);
 EXPORT_SYMBOL(console_drivers);
 
 EXPORT_SYMBOL(tb_ticks_per_usec);
--- linux-2.6.11-rc2-mm2-full/arch/h8300/kernel/h8300_ksyms.c.old	2005-01-31 14:17:34.000000000 +0100
+++ linux-2.6.11-rc2-mm2-full/arch/h8300/kernel/h8300_ksyms.c	2005-01-31 14:17:38.000000000 +0100
@@ -57,8 +57,6 @@
 EXPORT_SYMBOL(memscan);
 EXPORT_SYMBOL(memmove);
 
-EXPORT_SYMBOL(get_wchan);
-
 /*
  * libgcc functions - functions that are used internally by the
  * compiler...  (prototypes are not correct though, but that
--- linux-2.6.11-rc2-mm2-full/arch/x86_64/kernel/x8664_ksyms.c.old	2005-01-31 14:17:46.000000000 +0100
+++ linux-2.6.11-rc2-mm2-full/arch/x86_64/kernel/x8664_ksyms.c	2005-01-31 14:17:50.000000000 +0100
@@ -126,8 +126,6 @@
 EXPORT_SYMBOL(screen_info);
 #endif
 
-EXPORT_SYMBOL(get_wchan);
-
 EXPORT_SYMBOL(rtc_lock);
 
 EXPORT_SYMBOL_GPL(set_nmi_callback);
--- linux-2.6.11-rc2-mm2-full/arch/frv/kernel/frv_ksyms.c.old	2005-01-31 14:17:58.000000000 +0100
+++ linux-2.6.11-rc2-mm2-full/arch/frv/kernel/frv_ksyms.c	2005-01-31 14:18:03.000000000 +0100
@@ -73,8 +73,6 @@
 EXPORT_SYMBOL(memmove);
 EXPORT_SYMBOL(strtok);
 
-EXPORT_SYMBOL(get_wchan);
-
 #ifdef CONFIG_FRV_OUTOFLINE_ATOMIC_OPS
 EXPORT_SYMBOL(atomic_test_and_ANDNOT_mask);
 EXPORT_SYMBOL(atomic_test_and_OR_mask);


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RFC: 2.6 patch] unexport get_wchan
  2005-01-31 13:36 [RFC: 2.6 patch] unexport get_wchan Adrian Bunk
@ 2005-01-31 14:04 ` Greg Banks
  2005-10-31  5:30   ` Adrian Bunk
  0 siblings, 1 reply; 3+ messages in thread
From: Greg Banks @ 2005-01-31 14:04 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: linux-kernel

On Mon, Jan 31, 2005 at 02:36:17PM +0100, Adrian Bunk wrote:
> The only user of get_wchan I was able to find is the proc fs - and proc 
> can't be built modular.
> 
> Is the patch below to remove the export of get_wchan correct or did I 
> oversee something?

I have an oprofile patch queued up which uses get_wchan.  Oprofile
can be built modular.

Greg.
-- 
Greg Banks, R&D Software Engineer, SGI Australian Software Group.
I don't speak for SGI.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RFC: 2.6 patch] unexport get_wchan
  2005-01-31 14:04 ` Greg Banks
@ 2005-10-31  5:30   ` Adrian Bunk
  0 siblings, 0 replies; 3+ messages in thread
From: Adrian Bunk @ 2005-10-31  5:30 UTC (permalink / raw)
  To: Greg Banks; +Cc: linux-kernel

On Tue, Feb 01, 2005 at 01:04:00AM +1100, Greg Banks wrote:
> On Mon, Jan 31, 2005 at 02:36:17PM +0100, Adrian Bunk wrote:
> > The only user of get_wchan I was able to find is the proc fs - and proc 
> > can't be built modular.
> > 
> > Is the patch below to remove the export of get_wchan correct or did I 
> > oversee something?
> 
> I have an oprofile patch queued up which uses get_wchan.  Oprofile
> can be built modular.

What happened with this patch that would use get_wchan?

> Greg.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2005-10-31  5:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-31 13:36 [RFC: 2.6 patch] unexport get_wchan Adrian Bunk
2005-01-31 14:04 ` Greg Banks
2005-10-31  5:30   ` Adrian Bunk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox