From: Adrian Bunk <bunk@stusta.de>
To: R.E.Wolff@BitWizard.nl
Cc: linux-kernel@vger.kernel.org
Subject: [2.6 patch] drivers/char/specialix.c: misc cleanups
Date: Mon, 31 Jan 2005 18:36:54 +0100 [thread overview]
Message-ID: <20050131173654.GT18316@stusta.de> (raw)
This patch contains the following cleanups:
- make some needlessly global code static
- remove the unused global function specialix_setup
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/char/specialix.c | 43 +++++----------------------------------
1 files changed, 6 insertions(+), 37 deletions(-)
--- linux-2.6.11-rc2-mm2-full/drivers/char/specialix.c.old 2005-01-31 15:06:25.000000000 +0100
+++ linux-2.6.11-rc2-mm2-full/drivers/char/specialix.c 2005-01-31 15:07:39.000000000 +0100
@@ -372,7 +372,7 @@
/* Set the IRQ using the RTS lines that run to the PAL on the board.... */
-int sx_set_irq ( struct specialix_board *bp)
+static int sx_set_irq ( struct specialix_board *bp)
{
int virq;
int i;
@@ -439,7 +439,7 @@
}
-int read_cross_byte (struct specialix_board *bp, int reg, int bit)
+static int read_cross_byte (struct specialix_board *bp, int reg, int bit)
{
int i;
int t;
@@ -985,7 +985,7 @@
* Routines for open & close processing.
*/
-void turn_ints_off (struct specialix_board *bp)
+static void turn_ints_off (struct specialix_board *bp)
{
unsigned long flags;
func_enter ();
@@ -1004,7 +1004,7 @@
func_exit ();
}
-void turn_ints_on (struct specialix_board *bp)
+static void turn_ints_on (struct specialix_board *bp)
{
unsigned long flags;
@@ -2478,37 +2478,6 @@
}
-#ifndef MODULE
-/*
- * Called at boot time.
- *
- * You can specify IO base for up to SX_NBOARD cards,
- * using line "specialix=0xiobase1,0xiobase2,.." at LILO prompt.
- * Note that there will be no probing at default
- * addresses in this case.
- *
- */
-void specialix_setup(char *str, int * ints)
-{
- int i;
-
- func_enter ();
-
- for (i=0;i<SX_NBOARD;i++) {
- sx_board[i].base = 0;
- }
-
- for (i = 1; i <= ints[0]; i++) {
- if (i&1)
- sx_board[i/2].base = ints[i];
- else
- sx_board[i/2 -1].irq = ints[i];
- }
-
- func_exit ();
-}
-#endif
-
/*
* This routine must be called by kernel at boot time
*/
@@ -2579,9 +2548,9 @@
return 0;
}
-int iobase[SX_NBOARD] = {0,};
+static int iobase[SX_NBOARD] = {0,};
-int irq [SX_NBOARD] = {0,};
+static int irq [SX_NBOARD] = {0,};
module_param_array(iobase, int, NULL, 0);
module_param_array(irq, int, NULL, 0);
next reply other threads:[~2005-01-31 17:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-31 17:36 Adrian Bunk [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-02-24 23:39 [2.6 patch] drivers/char/specialix.c: misc cleanups Adrian Bunk
2004-12-05 17:16 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050131173654.GT18316@stusta.de \
--to=bunk@stusta.de \
--cc=R.E.Wolff@BitWizard.nl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox