Re: [PATCH] Fix SERIAL_TXX9 dependencies

[Ralf Baechle <ralf@linux-mips.org>]

On Mon, Jan 31, 2005 at 09:23:10PM +0100, Arnd Bergmann wrote:

> On Sünndag 30 Januar 2005 17:58, Ralf Baechle wrote:
> > Hmm...  Atushi sent me this new-style serial driver when I asked him for
> > replacements for the old style drivers in drivers/char/ so my undertanding
> > was it was a full replacement for all of them.  I'll check on the tx3912
> > and will try to send an update later today.
> 
> I just found that the version in -mm2 does not add the Makefile change, so
> you need this patchlet on top. If you haven't redone the patch yet, it might
> be better still to rename the file to txx9.o, as serial/serial_* is a bit
> redundant.

As for the TX3912 issue, there is no remaining user so that driver would
now be continuing to suffer from accelerated bitrot.  A rewrite to use
the drivers/serial infrastructure is relativly minor and so I and Atushi
Nemoto agree in that the old driver should stay removed, as my patch did
and therefore there was no need for rerolling the patch.  Akpm has in
the meantime sent the patches to Linus, so what's left would be renaming
the driver, as per your suggestion.

  Ralf