From: Stelian Pop <stelian@popies.net>
To: dtor_core@ameritech.net
Cc: Adrian Bunk <bunk@stusta.de>, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] drivers/char/sonypi.c: make 3 structs static
Date: Mon, 31 Jan 2005 23:27:54 +0100 [thread overview]
Message-ID: <20050131222753.GG28886@deep-space-9.dsnet> (raw)
In-Reply-To: <d120d500050131141358ff63c9@mail.gmail.com>
On Mon, Jan 31, 2005 at 05:13:22PM -0500, Dmitry Torokhov wrote:
> On Mon, 31 Jan 2005 22:49:05 +0100, Stelian Pop <stelian@popies.net> wrote:
> >
> > sonypi.h is a "local" header file used only by sonypi.c.
> >
> > I would like to keep those tables in sonypi.h rather than putting
> > all into sonypi.c (or we could as well remove sonypi.h and put all the
> > contents into the .c).
> >
>
> Hi,
>
> What is the point of having an .h file if it is not used by anyone?
> Judging by the fact that it completely protected by #ifdef __KERNEL__
> there should be no userspace clients either.
>
> I always thought that the only time .h is needed is when you define
> interface to your code. I'd fold it to sonpypi.c.
It isn't strictly *needed*, but it does separate a bit the data
structures and the constants (in the .h) from the code (in the .c).
Stelian.
--
Stelian Pop <stelian@popies.net>
next prev parent reply other threads:[~2005-01-31 22:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-31 17:35 [2.6 patch] drivers/char/sonypi.c: make 3 structs static Adrian Bunk
2005-01-31 21:49 ` Stelian Pop
2005-01-31 21:53 ` Adrian Bunk
2005-01-31 22:13 ` Dmitry Torokhov
2005-01-31 22:27 ` Stelian Pop [this message]
2005-01-31 22:39 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050131222753.GG28886@deep-space-9.dsnet \
--to=stelian@popies.net \
--cc=bunk@stusta.de \
--cc=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox