public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: "David S. Miller" <davem@davemloft.net>
Cc: akpm@osdl.org, ralf@linux-mips.org, davem@redhat.com,
	jgarzik@pobox.com, linux-net@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [2.6 patch] remove dp83840.h
Date: Tue, 1 Feb 2005 01:29:32 +0100	[thread overview]
Message-ID: <20050201002932.GC8722@stusta.de> (raw)
In-Reply-To: <20050131154607.70786f2c.davem@davemloft.net>

On Mon, Jan 31, 2005 at 03:46:07PM -0800, David S. Miller wrote:
> On Tue, 1 Feb 2005 00:41:58 +0100
> Adrian Bunk <bunk@stusta.de> wrote:
> 
> > dp83840.h is included once but none of the definitions it contains is
> > actually used.
> > 
> > Ralf Baechle wants that it stays as documentation, so this patch moves 
> > it under Documentation/ .
> 
> No, let's kill this thing altogether.  The only driver in the world
> using the CSCONFIG_* defines in there is the sunhme driver and it
> defines it's own macros in drivers/net/sunhme.h  This header is more
> than useless these days.
> 
> The header still exists in older trees and the revision history.
> So people can still get to it there.

OK, patch below

cu
Adrian


<--  snip  -->


dp83840.h is included once but none of the definitions it contains is
actually used.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 drivers/net/ioc3-eth.c               |    1 
 include/linux/dp83840.h              |   41 ---------------------------
 2 files changed, 42 deletions(-)

--- linux-2.6.10-rc2-mm3-full/drivers/net/ioc3-eth.c.old	2004-11-29 12:14:25.000000000 +0100
+++ linux-2.6.10-rc2-mm3-full/drivers/net/ioc3-eth.c	2004-11-29 12:14:34.000000000 +0100
@@ -56,7 +56,6 @@
 #include <linux/etherdevice.h>
 #include <linux/ethtool.h>
 #include <linux/skbuff.h>
-#include <linux/dp83840.h>
 #include <net/ip.h>
 
 #include <asm/byteorder.h>
--- linux-2.6.10-rc2-mm3-full/include/linux/dp83840.h	2004-10-18 23:54:32.000000000 +0200
+++ /dev/null	2004-11-25 03:16:25.000000000 +0100
@@ -1,41 +0,0 @@
-/*
- * linux/dp83840.h: definitions for DP83840 MII-compatible transceivers
- *
- * Copyright (C) 1996, 1999 David S. Miller (davem@redhat.com)
- */
-#ifndef __LINUX_DP83840_H
-#define __LINUX_DP83840_H
-
-#include <linux/mii.h>
-
-/*
- * Data sheets and programming docs for the DP83840 are available at
- * from http://www.national.com/
- *
- * The DP83840 is capable of both 10 and 100Mbps ethernet, in both
- * half and full duplex mode.  It also supports auto negotiation.
- *
- * But.... THIS THING IS A PAIN IN THE ASS TO PROGRAM!
- * Debugging eeprom burnt code is more fun than programming this chip!
- */
-
-/* First, the MII register numbers (actually DP83840 register numbers). */
-#define MII_CSCONFIG        0x17        /* CS configuration            */
-
-/* The Carrier Sense config register. */
-#define CSCONFIG_RESV1          0x0001  /* Unused...                   */
-#define CSCONFIG_LED4           0x0002  /* Pin for full-dplx LED4      */
-#define CSCONFIG_LED1           0x0004  /* Pin for conn-status LED1    */
-#define CSCONFIG_RESV2          0x0008  /* Unused...                   */
-#define CSCONFIG_TCVDISAB       0x0010  /* Turns off the transceiver   */
-#define CSCONFIG_DFBYPASS       0x0020  /* Bypass disconnect function  */
-#define CSCONFIG_GLFORCE        0x0040  /* Good link force for 100mbps */
-#define CSCONFIG_CLKTRISTATE    0x0080  /* Tristate 25m clock          */
-#define CSCONFIG_RESV3          0x0700  /* Unused...                   */
-#define CSCONFIG_ENCODE         0x0800  /* 1=MLT-3, 0=binary           */
-#define CSCONFIG_RENABLE        0x1000  /* Repeater mode enable        */
-#define CSCONFIG_TCDISABLE      0x2000  /* Disable timeout counter     */
-#define CSCONFIG_RESV4          0x4000  /* Unused...                   */
-#define CSCONFIG_NDISABLE       0x8000  /* Disable NRZI                */
-
-#endif /* __LINUX_DP83840_H */


  parent reply	other threads:[~2005-02-01  0:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-31 23:41 [2.6 patch] move dp83840.h to Documentation/ Adrian Bunk
2005-01-31 23:46 ` David S. Miller
2005-01-31 23:57   ` Jeff Garzik
2005-02-01  0:29   ` Adrian Bunk [this message]
2005-02-02  5:34     ` [2.6 patch] remove dp83840.h Jeff Garzik
2005-02-01  0:02 ` [2.6 patch] move dp83840.h to Documentation/ Ralf Baechle
  -- strict thread matches above, loose matches on Subject: below --
2004-11-29 11:19 [2.6 patch] remove dp83840.h Adrian Bunk
2004-11-29 11:36 ` Ralf Baechle
2004-11-29 15:34   ` Adrian Bunk
2004-12-02 11:26   ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050201002932.GC8722@stusta.de \
    --to=bunk@stusta.de \
    --cc=akpm@osdl.org \
    --cc=davem@davemloft.net \
    --cc=davem@redhat.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net@vger.kernel.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox