* I2C algorithm IDs
@ 2005-01-22 17:47 Russell King
2005-02-01 7:19 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Russell King @ 2005-01-22 17:47 UTC (permalink / raw)
To: Greg KH; +Cc: Linux Kernel List
Greg,
Are I2C algorithm IDs supposed to be unique? Do they have any meaning in
reality at all? If the answer is yes to either of these questions, the
following should probably be resolved:
#define I2C_ALGO_PCA 0x150000 /* PCA 9564 style adapters */
#define I2C_ALGO_SIBYTE 0x150000 /* Broadcom SiByte SOCs */
--
Russell King
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: I2C algorithm IDs
2005-01-22 17:47 I2C algorithm IDs Russell King
@ 2005-02-01 7:19 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2005-02-01 7:19 UTC (permalink / raw)
To: Linux Kernel List
On Sat, Jan 22, 2005 at 05:47:18PM +0000, Russell King wrote:
> Greg,
>
> Are I2C algorithm IDs supposed to be unique? Do they have any meaning in
> reality at all? If the answer is yes to either of these questions, the
> following should probably be resolved:
Yes, they are used in some places, and yes they do need to be unique.
> #define I2C_ALGO_PCA 0x150000 /* PCA 9564 style adapters */
> #define I2C_ALGO_SIBYTE 0x150000 /* Broadcom SiByte SOCs */
Thanks for pointing this out, I've gone and fixed this up and will send
the patch upward.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-02-01 7:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-22 17:47 I2C algorithm IDs Russell King
2005-02-01 7:19 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox