public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pete Zaitcev <zaitcev@redhat.com>
To: linux-poweredge@dell.com
Cc: zaitcev@redhat.com, linux-precision@dell.com,
	linux-kernel@vger.kernel.org
Subject: Patch to enable the USB handoff on Dell 650
Date: Tue, 1 Feb 2005 10:02:41 -0800	[thread overview]
Message-ID: <20050201100241.07c6c504@localhost.localdomain> (raw)

Hi, guys,

I was looking at this:
  https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=138892

  I have added usb-handoff as a kernel option in grub.conf for
  2.4.21-20.EL (smp) and re-enabled USB Emulation and Controller in the
  BIOS, and the machine now seems to boot normally.  I only had time to
  try booting it twice, but previously it would fail almost every time,
  so two successive successful boots seems very good.  Thanks for your
  quick responses and working solution!

Can someone with the Dell PW650 (which, I think, should be same as PE600)
test this patch for me? I do not want to send this for inclusion into
Linus' kernel before it's tested.

In theory we probably will want USB handoff to be enabled by default, but
I am not sure this time is now, so let us use DMI lists until then.

Thanks,
-- Pete

--- linux-2.6.11-rc2/arch/i386/kernel/dmi_scan.c	2005-01-22 14:53:59.000000000 -0800
+++ linux-2.6.11-rc2-lem/arch/i386/kernel/dmi_scan.c	2005-01-31 20:42:16.163592792 -0800
@@ -243,6 +243,19 @@
 }  
 #endif
 
+static __init int enable_usb_handoff(struct dmi_blacklist *d)
+{
+	extern int usb_early_handoff;
+
+	/*
+	 * A printk is probably unnecessary. There's no way this causes
+	 * any harm (famous last words). But seriously, we only add systems
+	 * to the list if we know that they need handoff for sure.
+	 */
+	usb_early_handoff = 1;
+	return 0;
+}
+
 /*
  *	Process the DMI blacklists
  */
@@ -376,6 +389,14 @@
 
 #endif
 
+	/*
+	 *	Boxes which need USB taken over from BIOS explicitly.
+	 */
+	{ enable_usb_handoff, "Dell PW650", {
+			MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"),
+			MATCH(DMI_PRODUCT_NAME, "Precision WorkStation 650"),
+			NO_MATCH, NO_MATCH }},
+
 	{ NULL, }
 };
 

             reply	other threads:[~2005-02-01 18:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-01 18:02 Pete Zaitcev [this message]
2005-02-02  7:18 ` Patch to enable the USB handoff on Dell 650 Andrey Panin
2005-03-04 20:17   ` Pete Zaitcev
2005-03-10  8:16     ` Andrey Panin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050201100241.07c6c504@localhost.localdomain \
    --to=zaitcev@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-poweredge@dell.com \
    --cc=linux-precision@dell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox