Re: [PATCH 1/1] pci: Block config access during BIST (resend)

Brian King
2005-01-11T22:21:57Z

Andi Kleen wrote:
> On Tue, Jan 11, 2005 at 02:37:40PM +0000, Alan Cox wrote:
>
>>On Llu, 2005-01-10 at 22:57, Brian King wrote:
>>
>>>>For this I would add a semaphore or a lock bit to pci_dev.
>>>>Probably a simple flag is good enough that is checked by sysfs/proc
>>>>and return EBUSY when set.
>>>
>>>How about something like this... (only compile tested at this point)
>>
>>
>>User space does not expect to get dumped with -EBUSY randomly on PCI
>
>
> I think it's a reasonable thing to do. If you prefer you could fake a
> 0xffffffff read, that would look like busy or non existing hardware.
> But the errno would seem to be cleaner to me.

We can certainly go either way. I decided to go the way I did simply
because that was what was suggested.

> There may be other reasons to have error codes here in the future
> too - e.g. with the upcomming support for real PCI error handling
> it would make a lot of sense to return EIO in some cases. User space
> will just have to cope with that.
>
>
>>accesses. Not a viable option in that form _but_ making them sleep would
>>work - even with a simple global wait queue
>>for the pci_unblock_.. path
>>
>>ie add the following (oh and uninlined probably for compatcness)
>>
>>static int pci_user_wait_access(struct pci_dev *pdev) {
>> wait_event(&pci_ucfg_wait, dev->block_ucfg_access == 0);
>>}
>
>
> I don't like this very much. What happens when the device
> doesn't get out of BIST for some reason?
>
> I think it's better to keep this simple, and an error is fine for that.

Also, Ben Herrenschmidt expressed a desire to use this interface in
dealing with some power management issues on G5's. The issue is that
when some devices are powered off on G5 they will not respond to config
cycles and may even deadlock the system. This usage would require the
ability to block userspace for an indefinite period of time and also
make use of the config space caching code that is in my patch.

-Brian

--
Brian King
eServer Storage I/O
IBM Linux Technology Center