Re: [PATCH 1/2] pci: Block config access during BIST (resend)

Andrew Morton
2005-09-01T23:01:49Z

Brian King <brking@us.ibm.com> wrote:
>
> +void pci_block_user_cfg_access(struct pci_dev *dev)
> +{
> + unsigned long flags;
> +
> + pci_save_state(dev);
> + spin_lock_irqsave(&pci_lock, flags);
> + dev->block_ucfg_access = 1;
> + spin_unlock_irqrestore(&pci_lock, flags);

Are you sure the locking in here is meaningful? All it will really do is
give you a couple of barriers.