Re: [PATCH 1/1] pci: Block config access during BIST (resend)

Alan Cox
2005-01-13T19:37:20Z

On Maw, 2005-01-11 at 17:33, Andi Kleen wrote:
> > User space does not expect to get dumped with -EBUSY randomly on PCI
>
> I think it's a reasonable thing to do. If you prefer you could fake a
> 0xffffffff read, that would look like busy or non existing hardware.
> But the errno would seem to be cleaner to me.

Either will break X.

> > static int pci_user_wait_access(struct pci_dev *pdev) {
> > wait_event(&pci_ucfg_wait, dev->block_ucfg_access == 0);
> > }
>
> I don't like this very much. What happens when the device
> doesn't get out of BIST for some reason?

Then you need to switch to wait_event_timeout(). Its not terribly hard
8)