Re: [PATCH 1/1] pci: Block config access during BIST (resend)

Matthew Wilcox
2005-02-01T17:48:34Z

On Tue, Feb 01, 2005 at 11:35:05AM -0600, Brian King wrote:
> >If we've done a write to config space while the adapter was blocked,
> >shouldn't we replay those accesses at this point?
>
> I did not think that was necessary.

We have to do *something*. We can't just throw away writes.

I see a few options:

- Log all pending writes to config space and replay the log when the
device is unblocked.
- Fail writes to config space while the device is blocked.
- Write to the saved config space and then blat the saved config space
back to the device upon unblocking.

Any other ideas?

BTW, you know things like XFree86 go completely around the kernel's PCI
accessors and poke at config space directly?

--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain