Re: [PATCH 1/1] pci: Block config access during BIST (resend)

Andi Kleen
2005-01-13T18:07:38Z

On Thu, Jan 13, 2005 at 03:35:59PM +0000, Alan Cox wrote:
> On Maw, 2005-01-11 at 17:33, Andi Kleen wrote:
> > > User space does not expect to get dumped with -EBUSY randomly on PCI
> >
> > I think it's a reasonable thing to do. If you prefer you could fake a
> > 0xffffffff read, that would look like busy or non existing hardware.
> > But the errno would seem to be cleaner to me.
>
> Either will break X.

You are saying that X during its own private broken PCI scan
stops scanning when it sees an errno?

That sounds incredibly broken if true. I'm not sure how much
effort the kernel should really take to work around such
user breakage. I suppose an ffffffff return would work.

>
> > > static int pci_user_wait_access(struct pci_dev *pdev) {
> > > wait_event(&pci_ucfg_wait, dev->block_ucfg_access == 0);
> > > }
> >
> > I don't like this very much. What happens when the device
> > doesn't get out of BIST for some reason?
>
> Then you need to switch to wait_event_timeout(). Its not terribly hard
> 8)

Just complicating something that should be very simple.

-Andi