Re: Patch to enable the USB handoff on Dell 650

[Andrey Panin <pazke@donpac.ru>]

[-- Attachment #1: Type: text/plain, Size: 2153 bytes --]

On 032, 02 01, 2005 at 10:02:41AM -0800, Pete Zaitcev wrote:
> Hi, guys,
> 
> I was looking at this:
>   https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=138892
> 
>   I have added usb-handoff as a kernel option in grub.conf for
>   2.4.21-20.EL (smp) and re-enabled USB Emulation and Controller in the
>   BIOS, and the machine now seems to boot normally.  I only had time to
>   try booting it twice, but previously it would fail almost every time,
>   so two successive successful boots seems very good.  Thanks for your
>   quick responses and working solution!
> 
> Can someone with the Dell PW650 (which, I think, should be same as PE600)
> test this patch for me? I do not want to send this for inclusion into
> Linus' kernel before it's tested.
> 
> In theory we probably will want USB handoff to be enabled by default, but
> I am not sure this time is now, so let us use DMI lists until then.
> 
> Thanks,
> -- Pete
> 
> --- linux-2.6.11-rc2/arch/i386/kernel/dmi_scan.c	2005-01-22 14:53:59.000000000 -0800
> +++ linux-2.6.11-rc2-lem/arch/i386/kernel/dmi_scan.c	2005-01-31 20:42:16.163592792 -0800
> @@ -243,6 +243,19 @@
>  }  
>  #endif
>  
> +static __init int enable_usb_handoff(struct dmi_blacklist *d)
> +{
> +	extern int usb_early_handoff;
> +
> +	/*
> +	 * A printk is probably unnecessary. There's no way this causes
> +	 * any harm (famous last words). But seriously, we only add systems
> +	 * to the list if we know that they need handoff for sure.
> +	 */
> +	usb_early_handoff = 1;
> +	return 0;
> +}
> +

Please don't add new quirks into dmi_scan.c. Use dmi_check_system()
where possible.

>  /*
>   *	Process the DMI blacklists
>   */
> @@ -376,6 +389,14 @@
>  
>  #endif
>  
> +	/*
> +	 *	Boxes which need USB taken over from BIOS explicitly.
> +	 */
> +	{ enable_usb_handoff, "Dell PW650", {
> +			MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"),
> +			MATCH(DMI_PRODUCT_NAME, "Precision WorkStation 650"),
> +			NO_MATCH, NO_MATCH }},
> +
>  	{ NULL, }

-- 
Andrey Panin		| Linux and UNIX system administrator
pazke@donpac.ru		| PGP key: wwwkeys.pgp.net

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]