public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Pavel Machek <pavel@suse.cz>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Arjan van de Ven <arjan@infradead.org>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Andrea Arcangeli <andrea@suse.de>,
	George Anzinger <george@mvista.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	john stultz <johnstul@us.ibm.com>,
	Zwane Mwaikambo <zwane@arm.linux.org.uk>,
	Lee Revell <rlrevell@joe-job.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Dynamic tick, version 050127-1
Date: Wed, 2 Feb 2005 19:04:00 -0800	[thread overview]
Message-ID: <20050203030359.GL13984@atomide.com> (raw)
In-Reply-To: <20050202141105.GA1316@elf.ucw.cz>

[-- Attachment #1: Type: text/plain, Size: 1356 bytes --]

* Pavel Machek <pavel@suse.cz> [050202 06:13]:
> 
> Hi!
> 
> > > > > I used your config advices from second mail, still it does not work as
> > > > > expected: system gets "too sleepy". Like it takes a nap during boot
> > > > > after "dyn-tick: Maximum ticks to skip limited to 1339", and key is
> > > > > needed to make it continue boot. Then cursor stops blinking and
> > > > > machine is hung at random intervals during use, key is enough to awake
> > > > > it.
> > > > 
> > > > Hmmm, that sounds like the local APIC does not wake up the PIT
> > > > interrupt properly after sleep. Hitting the keys causes the timer
> > > > interrupt to get called, and that explains why it keeps running. But
> > > > the timer ticks are not happening as they should for some reason.
> > > > This should not happen (tm)...
> > > 
> > > :-). Any ideas how to debug it? Previous version of patch seemed to work better...
> > 
> > I don't think it's HPET timer, or CONFIG_SMP. It also looks like your
> > local APIC timer is working.
> 
> I turned off CONFIG_PREEMPT, but nothing changed :-(.

What about reprogramming the timers in time.c after the sleep? Do
you to dyn_tick->skip = 1; part in dyn_tick_timer_interrupt?

It could also be that the reprogamming of PIT timer does not work on
your machine. I chopped off the udelays there... Can you try
something like this:

[-- Attachment #2: patch-pit-udelay --]
[-- Type: text/plain, Size: 414 bytes --]

--- a/arch/i386/kernel/time.c	2005-01-27 12:58:04 -08:00
+++ b/arch/i368/kernel/time.c	2005-02-02 19:01:31 -08:00
@@ -479,8 +480,11 @@
 
 	spin_lock_irqsave(&i8253_lock, flags);
 	outb_p(0x34, PIT_MODE);		/* binary, mode 2, LSB/MSB, ch 0 */
+	udelay(10);
 	outb_p(skip & 0xff, PIT_CH0);	/* LSB */
+	udelay(10);
 	outb(skip >> 8, PIT_CH0);	/* MSB */
+	udelay(10);
 	spin_unlock_irqrestore(&i8253_lock, flags);
 }
 

  reply	other threads:[~2005-02-03  3:05 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-27 21:29 [PATCH] Dynamic tick, version 050127-1 Tony Lindgren
2005-01-27 21:50 ` Tony Lindgren
2005-02-01 11:00 ` Pavel Machek
2005-02-01 20:40   ` Tony Lindgren
2005-02-01 21:25     ` Pavel Machek
2005-02-01 23:03       ` Tony Lindgren
2005-02-02 13:50         ` Pavel Machek
2005-02-02 13:50         ` Pavel Machek
2005-02-02 13:56         ` Pavel Machek
2005-02-02 14:11         ` Pavel Machek
2005-02-03  3:04           ` Tony Lindgren [this message]
2005-02-03 10:56             ` Pavel Machek
2005-02-03 16:43               ` Tony Lindgren
2005-02-04  5:19                 ` Tony Lindgren
2005-02-04  6:33                   ` Zwane Mwaikambo
2005-02-04 17:18                     ` Tony Lindgren
2005-02-04 17:31                       ` Zwane Mwaikambo
2005-02-04 17:42                         ` Tony Lindgren
2005-02-04 17:54                           ` Zwane Mwaikambo
2005-02-04 18:58                             ` Tony Lindgren
2005-02-04 19:24                               ` Tony Lindgren
2005-02-05 23:00                   ` Pavel Machek
2005-02-06  2:33                     ` Tony Lindgren
2005-02-06  3:54                       ` Tony Lindgren
2005-02-06  8:41                         ` Pavel Machek
2005-02-06  8:50                         ` Pavel Machek
2005-02-06 17:07                           ` Tony Lindgren
2005-02-06 12:15                         ` Pavel Machek
2005-02-06 17:08                           ` Tony Lindgren
2005-02-06  8:11                       ` Pavel Machek
2005-02-06  8:53                         ` Lee Revell
2005-02-06 10:25                           ` Pavel Machek
2005-02-07 22:08                             ` George Anzinger
2005-02-06 17:10                         ` Tony Lindgren
2005-02-06 18:34                           ` Pavel Machek
2005-02-01 20:20 ` Lee Revell
2005-02-01 23:42   ` Tony Lindgren
2005-02-02  1:06   ` Eric St-Laurent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050203030359.GL13984@atomide.com \
    --to=tony@atomide.com \
    --cc=andrea@suse.de \
    --cc=arjan@infradead.org \
    --cc=benh@kernel.crashing.org \
    --cc=george@mvista.com \
    --cc=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@suse.cz \
    --cc=rlrevell@joe-job.com \
    --cc=schwidefsky@de.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=zwane@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox