Re: [PATCH] radeonfb update (new patch)

Re: [PATCH] radeonfb update (new patch)

[Andrew Morton]

Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> This patch against current bk replaces the previous one I sent you.
> 
>  It adds the sleep support for newer powermacs, improve power saving on
>  some laptops, makes use of the new fbdev modelist management routines,
>  and fixes a few backlight related issues.
> 
>  I tested it on a thinkpad T30 and a few PPC boxes with success. It
>  should be less invasive than the previous one (I don't try to restore
>  the mode on exit, that is what breaks the thinkpad and possibly other
>  stuffs that boot in VGA text mode), plus fixed a couple of bugs in the
>  mode detection code. I also reverted the memory map fix on ppc since it
>  doesn't work properly on some recent laptops where the firmware sets a
>  tiled display. I'll rework that completely to update the memory map as
>  part of the mode setting later. That should fix various issues when
>  switching with X/DRI on x86.
> 
>  Andrew: If Linus takes it, you'll need to send him the patch that
>  fixes the old radeonfb build.

I don't think Linus _can_ apply it - he doesn't have
try_acquire_console_sem() for a start.

I currently have:

add-try_acquire_console_sem.patch
update-aty128fb-sleep-wakeup-code-for-new-powermac-changes.patch
radeonfb-massive-update-of-pm-code.patch
radeonfb-build-fix.patch

And the patch which you've just send replaces
radeonfb-massive-update-of-pm-code.patch.

Please confirm that all four are needed.

Are you seriously proposing this for 2.6.11??

Re: [PATCH] radeonfb update (new patch)

[Benjamin Herrenschmidt]

On Wed, 2005-02-02 at 22:27 -0800, Andrew Morton wrote:

> I don't think Linus _can_ apply it - he doesn't have
> try_acquire_console_sem() for a start.

Right, that's a pre-req.

> I currently have:
> 
> add-try_acquire_console_sem.patch
> update-aty128fb-sleep-wakeup-code-for-new-powermac-changes.patch
> radeonfb-massive-update-of-pm-code.patch
> radeonfb-build-fix.patch
> 
> And the patch which you've just send replaces
> radeonfb-massive-update-of-pm-code.patch.

Yes.

> Please confirm that all four are needed.
> 
> Are you seriously proposing this for 2.6.11??

Well... There should be no problem with
add-try_acquire_console_sem.patch and
update-aty128fb-sleep-wakeup-code-for-new-powermac-changes.patch.

radeonfb is another story, but the newer patch is definitely less
invasive. It really just fixes bugs and adds the bulk of PM stuff to
wakeup the newer chips, plus some backlight changes. It's been tested by
pmac users for a while, the only reason I sent it to you only recently
is that i was away for a month !

I'm hesitating about having it in 2.6.11 tho due to linus wanting to
release real soon, I'd rather have a bit more non-ppc testing just in
case though... but now it depends entirely on when linus plans to get
2.6.11 out of the door.

Ben.

Re: [PATCH] radeonfb update (new patch)

[Arkadiusz Miskiewicz]

On Thursday 03 of February 2005 07:38, Benjamin Herrenschmidt wrote:

> > Are you seriously proposing this for 2.6.11??
>
> Well... There should be no problem with
> add-try_acquire_console_sem.patch and
> update-aty128fb-sleep-wakeup-code-for-new-powermac-changes.patch.
>
> radeonfb is another story, but the newer patch is definitely less
> invasive. It really just fixes bugs and adds the bulk of PM stuff to
> wakeup the newer chips, plus some backlight changes. It's been tested by
> pmac users for a while, the only reason I sent it to you only recently
> is that i was away for a month !
,,backlight changes'' - that interests me. My ibook g4 1.2GHz right now can 
sleep and wake up sometimes (with additional patch) but the backlight doesn't 
turn on or is very, very dark and I can't make it lighter from keyboard. Is 
this change related to such problems?

Generic question - how does suspend to ram/suspend to disk looks for ibook g4 
in current Linus and mm kernels?

> I'm hesitating about having it in 2.6.11 tho due to linus wanting to
> release real soon, I'd rather have a bit more non-ppc testing just in
> case though... but now it depends entirely on when linus plans to get
> 2.6.11 out of the door.
>
> Ben.

-- 
Arkadiusz Miśkiewicz                    PLD/Linux Team
http://www.t17.ds.pwr.wroc.pl/~misiek/  http://ftp.pld-linux.org/

Re: [PATCH] radeonfb update (new patch)

[Benjamin Herrenschmidt]

On Thu, 2005-02-03 at 09:11 +0100, Arkadiusz Miskiewicz wrote:
> On Thursday 03 of February 2005 07:38, Benjamin Herrenschmidt wrote:
> 
> > > Are you seriously proposing this for 2.6.11??
> >
> > Well... There should be no problem with
> > add-try_acquire_console_sem.patch and
> > update-aty128fb-sleep-wakeup-code-for-new-powermac-changes.patch.
> >
> > radeonfb is another story, but the newer patch is definitely less
> > invasive. It really just fixes bugs and adds the bulk of PM stuff to
> > wakeup the newer chips, plus some backlight changes. It's been tested by
> > pmac users for a while, the only reason I sent it to you only recently
> > is that i was away for a month !
> ,,backlight changes'' - that interests me. My ibook g4 1.2GHz right now can 
> sleep and wake up sometimes (with additional patch) but the backlight doesn't 
> turn on or is very, very dark and I can't make it lighter from keyboard. Is 
> this change related to such problems?

Yes. Please let me know if the patch makes it better.

> Generic question - how does suspend to ram/suspend to disk looks for ibook g4 
> in current Linus and mm kernels?

suspend-to-ram should work with this radeonfb patch.

> > I'm hesitating about having it in 2.6.11 tho due to linus wanting to
> > release real soon, I'd rather have a bit more non-ppc testing just in
> > case though... but now it depends entirely on when linus plans to get
> > 2.6.11 out of the door.
> >
> > Ben.
> 
-- 
Benjamin Herrenschmidt <benh@kernel.crashing.org>