public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Gerd Knorr <kraxel@bytesex.org>
To: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: mathieu.okuyama@free.fr, Linus Torvalds <torvalds@osdl.org>,
	Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux 2.6.11-rc3 - BT848 no signal
Date: Thu, 3 Feb 2005 12:30:22 +0100	[thread overview]
Message-ID: <20050203113022.GK10602@bytesex> (raw)
In-Reply-To: <1107428571.2068.4.camel@lb.loomes.de>

> > > mt2032_set_if_freq failed with -121
> 
> OK here you go.

Thanks, seems to be a initialization order bug which changes the default
state of the tda9887 output ports.  The patch below should fix that.

  Gerd

diff -u linux-2.6.11/drivers/media/video/tda9887.c linux/drivers/media/video/tda9887.c
--- linux-2.6.11/drivers/media/video/tda9887.c	2005-01-25 11:57:21.000000000 +0100
+++ linux/drivers/media/video/tda9887.c	2005-02-03 12:26:16.246003021 +0100
@@ -305,9 +305,9 @@
 	printk("  B5   force mute audio: %s\n",
 	       (buf[1] & 0x20) ? "yes" : "no");
 	printk("  B6   output port 1   : %s\n",
-	       (buf[1] & 0x40) ? "high" : "low");
+	       (buf[1] & 0x40) ? "high (inactive)" : "low (active)");
 	printk("  B7   output port 2   : %s\n",
-	       (buf[1] & 0x80) ? "high" : "low");
+	       (buf[1] & 0x80) ? "high (inactive)" : "low (active)");
 
 	printk(PREFIX "write: byte C 0x%02x\n",buf[2]);
 	printk("  C0-4 top adjustment  : %s dB\n", adjust[buf[2] & 0x1f]);
@@ -545,9 +545,9 @@
 	int rc;
 
 	memset(buf,0,sizeof(buf));
+	tda9887_set_tvnorm(t,buf);
 	buf[1] |= cOutputPort1Inactive;
 	buf[1] |= cOutputPort2Inactive;
-	tda9887_set_tvnorm(t,buf);
 	if (UNSET != t->pinnacle_id) {
 		tda9887_set_pinnacle(t,buf);
 	}

  reply	other threads:[~2005-02-03 11:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-03  2:35 Linux 2.6.11-rc3 Linus Torvalds
2005-02-03  5:19 ` Linux 2.6.11-rc3 - BT848 no signal Markus Trippelsdorf
2005-02-03 10:17   ` Gerd Knorr
2005-02-03 11:02     ` Markus Trippelsdorf
2005-02-03 11:30       ` Gerd Knorr [this message]
2005-02-03 12:02         ` Markus Trippelsdorf
2005-02-03 19:20         ` Mickael Marchand
2005-02-04 10:44           ` Guillaume Chazarain
2005-02-04 17:37             ` Mickael Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050203113022.GK10602@bytesex \
    --to=kraxel@bytesex.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markus@trippelsdorf.de \
    --cc=mathieu.okuyama@free.fr \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox