From: Dmitry Torokhov <dtor_core@ameritech.net>
To: Vojtech Pavlik <vojtech@suse.cz>
Cc: Stephen Evanchik <evanchsa@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.11-rc3] IBM Trackpoint support
Date: Fri, 4 Feb 2005 01:52:39 -0500 [thread overview]
Message-ID: <200502040152.39728.dtor_core@ameritech.net> (raw)
In-Reply-To: <20050204063520.GD2329@ucw.cz>
On Friday 04 February 2005 01:35, Vojtech Pavlik wrote:
> On Thu, Feb 03, 2005 at 07:34:16PM -0500, Dmitry Torokhov wrote:
> > On Thursday 03 February 2005 17:43, Stephen Evanchik wrote:
> > > Vojtech,
> > >
> > > Here is a patch that exposes the IBM TrackPoint's extended properties
> > > as well as scroll wheel emulation.
> > >
> > >
> >
> > Hi,
> >
> > Very nice although I have a couple of comments.
> >
> > > /*
> > > + * Try to initialize the IBM TrackPoint
> > > + */
> > > + if (max_proto > PSMOUSE_PS2 && trackpoint_init(psmouse) == 0) {
> > > + psmouse->vendor = "IBM";
> > > + psmouse->name = "TrackPoint";
> > > +
> > > + return PSMOUSE_PS2;
> >
> > Why PSMOUSE_PS2? Reconnect will surely not like it.
>
> Indeed. IIRC this patch killed wheel mouse detection in ubuntu.
>
We may need yet another psmouse_reset after unsuccessful test.
--
Dmitry
next prev parent reply other threads:[~2005-02-04 6:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-03 22:43 [PATCH 2.6.11-rc3] IBM Trackpoint support Stephen Evanchik
2005-02-04 0:34 ` Dmitry Torokhov
2005-02-04 3:52 ` Dmitry Torokhov
2005-02-04 4:39 ` Stephen Evanchik
2005-02-13 19:13 ` Stephen Evanchik
2005-02-13 19:31 ` Vojtech Pavlik
2005-02-13 20:31 ` Stephen Evanchik
2005-02-13 23:50 ` Dmitry Torokhov
2005-02-04 6:35 ` Vojtech Pavlik
2005-02-04 6:46 ` Fabio Massimo Di Nitto
2005-02-04 6:52 ` Dmitry Torokhov [this message]
2005-02-04 6:54 ` Vojtech Pavlik
2005-02-04 14:17 ` Dmitry Torokhov
2005-02-04 14:45 ` Vojtech Pavlik
2005-02-05 6:56 ` Dmitry Torokhov
2005-02-05 12:24 ` Vojtech Pavlik
2005-02-04 13:17 ` Stephen Evanchik
2005-02-04 13:45 ` Vojtech Pavlik
2005-02-04 14:12 ` Dmitry Torokhov
2005-02-05 10:44 ` Pavel Machek
2005-02-07 10:14 ` Vojtech Pavlik
2005-02-13 19:07 ` Stephen Evanchik
2005-02-13 19:13 ` Vojtech Pavlik
2005-02-06 20:17 ` Domen Puncer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200502040152.39728.dtor_core@ameritech.net \
--to=dtor_core@ameritech.net \
--cc=evanchsa@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox