Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

[Pavel Machek <pavel@suse.cz>]

Hi!

> Here is a patch that exposes the IBM TrackPoint's extended properties
> as well as scroll wheel emulation.
> 
> 
> I would appreciate comments and suggestions to make this more acceptable.
> 
> 
> Stephen
> 
> 
> diff -uNr a/drivers/input/mouse/Makefile b/drivers/input/mouse/Makefile
> --- a/drivers/input/mouse/Makefile	2005-02-03 17:30:40.000000000 -0500
> +++ b/drivers/input/mouse/Makefile	2005-02-03 17:29:42.000000000 -0500
> @@ -14,4 +14,4 @@
>  obj-$(CONFIG_MOUSE_SERIAL)	+= sermouse.o
>  obj-$(CONFIG_MOUSE_VSXXXAA)	+= vsxxxaa.o
>  
> -psmouse-objs  := psmouse-base.o alps.o logips2pp.o synaptics.o
> +psmouse-objs  := psmouse-base.o alps.o logips2pp.o synaptics.o trackpoint.o
> diff -uNr a/drivers/input/mouse/psmouse-base.c
> b/drivers/input/mouse/psmouse-base.c
> --- a/drivers/input/mouse/psmouse-base.c	2005-02-03 17:30:40.000000000 -0500
> +++ b/drivers/input/mouse/psmouse-base.c	2005-02-03 17:29:42.000000000 -0500
> @@ -23,6 +23,7 @@
>  #include "psmouse.h"
>  #include "synaptics.h"
>  #include "logips2pp.h"
> +#include "trackpoint.h"
>  #include "alps.h"
>  
>  #define DRIVER_DESC	"PS/2 mouse driver"
> @@ -119,6 +120,13 @@
>  	}
>  
>  /*
> + * TrackPoint scroll simulation handler if the BTN_MIDDLE is down
> + */
> +
> +	if(psmouse->model == PSMOUSE_TRACKPOINT)
> +		trackpoint_sim_scroll(psmouse);
> +
> +/*
>   * Generic PS/2 Mouse
>   */
>  

Perhaps this should be done in userspace? It is probably usable on
non-trackpoint devices, too...
									Pavel


-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!