public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] add compiler-gcc4.h
Date: Sat, 5 Feb 2005 20:38:13 +0100	[thread overview]
Message-ID: <20050205193813.GG3129@stusta.de> (raw)
In-Reply-To: <42051460.9060208@zytor.com>

On Sat, Feb 05, 2005 at 10:45:52AM -0800, H. Peter Anvin wrote:
> Adrian Bunk wrote:
> >
> >As I already said in this thread:
> >  The currently used file for gcc 4 is compiler-gcc+.h, not
> >  compiler-gcc3.h .
> >
> >And the current setup is to have one file for every major number of gcc.
> >I have no strong opinion whether this approach or the approach of one 
> >file for all gcc versions is better - but with the current approach, 
> >everything else than a separate file for gcc 4 wasn't logical.
> 
> Yes it is.  It's perfectly logical: gcc+ contains the "going forward" 
> version, and until it supports some feature that isn't in all versions 
> of gcc4, it's the right thing to do.
>...

It doesn't seem to be logical for everyone whether compiler-gcc+.h or 
compiler-gcc3.h is used for gcc 4.0 ...

Perhaps compiler-gcc+.h (which wasn't always updated when 
compiler-gcc3.h was updated) should be removed?

> 	-hpa

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  reply	other threads:[~2005-02-05 19:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-30 13:03 [2.6 patch] add compiler-gcc4.h Adrian Bunk
2005-01-30 14:11 ` Andi Kleen
2005-01-30 14:14   ` Adrian Bunk
2005-01-30 15:35   ` Matthias-Christian Ott
2005-02-03  1:04     ` H. Peter Anvin
2005-02-05 13:50       ` Adrian Bunk
2005-02-05 18:45         ` H. Peter Anvin
2005-02-05 19:38           ` Adrian Bunk [this message]
2005-02-05 19:52             ` H. Peter Anvin
2005-02-06  0:43               ` [RFC][PATCH-2.6] Clean up and merge compiler-*.h Kyle Moffett
2005-02-06  0:50               ` [2.6 patch] add compiler-gcc4.h Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050205193813.GG3129@stusta.de \
    --to=bunk@stusta.de \
    --cc=akpm@osdl.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox