From: Adrian Bunk <bunk@stusta.de>
To: perex@suse.cz
Cc: alsa-devel@alsa-project.org,
"emmanuel.colbus@ensimag.imag.fr" <colbuse@ensisun.imag.fr>,
linux-kernel@vger.kernel.org
Subject: [2.6 patch] fix sound/isa/gus/interwave.c compile with PNP=n
Date: Sun, 6 Feb 2005 19:44:21 +0100 [thread overview]
Message-ID: <20050206184421.GR3129@stusta.de> (raw)
Emmanuel Colbus sent this patch one month ago with the following
description:
There is a trivial bug in the file sound/isa/gus/interwave.c .
The variable isapnp is defined only if CONFIG_PNP is enabled, but it is
always used few lines after.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- a/sound/isa/gus/interwave.c Fri Dec 24 22:34:58 2004
+++ b/sound/isa/gus/interwave.c Wed Jan 5 14:06:53 2005
@@ -79,8 +79,10 @@
MODULE_PARM_DESC(id, "ID string for InterWave soundcard.");
module_param_array(enable, bool, NULL, 0444);
MODULE_PARM_DESC(enable, "Enable InterWave soundcard.");
+#ifdef CONFIG_PNP
module_param_array(isapnp, bool, NULL, 0444);
MODULE_PARM_DESC(isapnp, "ISA PnP detection for specified soundcard.");
+#endif
module_param_array(port, long, NULL, 0444);
MODULE_PARM_DESC(port, "Port # for InterWave driver.");
#ifdef SNDRV_STB
next reply other threads:[~2005-02-06 18:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-06 18:44 Adrian Bunk [this message]
2005-02-10 11:36 ` [Alsa-devel] [2.6 patch] fix sound/isa/gus/interwave.c compile with PNP=n Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050206184421.GR3129@stusta.de \
--to=bunk@stusta.de \
--cc=alsa-devel@alsa-project.org \
--cc=colbuse@ensisun.imag.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox