Re: [patch] ns558 bug

matthieu castet
2005-02-05T08:31:37Z

Hi,

Andrew Morton wrote:
> ambx1@neo.rr.com (Adam Belay) wrote:
>
>>On Fri, Feb 04, 2005 at 09:00:54PM +0100, matthieu castet wrote:
>> > Hi,
>> >
>> > this patch is based on http://bugzilla.kernel.org/show_bug.cgi?id=2962
>> > patch from adam belay.
>> >
>> > It solve a oops when pnp_register_driver(&ns558_pnp_driver) failed.
>> >
>> > Please apply this patch.
>> >
>> > Matthieu
>>
>> I remember writing a version of this patch a while ago. The current behavior
>> is broken because it shouldn't be considered a failure if the driver doesn't
>> find any devices.
Why ?
If isa detection failed, the modules could not find any new isa devices.
If the pnp detection find no device, the module is load.
If it is the kernel modules behaviour, lot's of modules are broken...

If you want that, why not simply alway "return 0" in the __init like it
is done in the bugzilla patch ?

Matthieu