Re: [patch] ns558 bug

Adam Belay
2005-02-05T03:33:47Z

On Fri, Feb 04, 2005 at 07:06:14PM -0800, Andrew Morton wrote:

It looks ok. My only concern is what would happen if the isa probe succeded
but the pnp_register_driver failed? "pnp_register_driver" return -ENODEV if
"CONFIG_PNP" isn't enabled. Do you think this would conflict with legacy
probing?

Thanks,
Adam

> So would this be the appropriate fix?
>
> --- 25/drivers/input/gameport/ns558.c~ns558-oops-fix 2005-02-04 19:03:11.065813120 -0800
> +++ 25-akpm/drivers/input/gameport/ns558.c 2005-02-04 19:05:52.607255088 -0800
> @@ -264,6 +264,7 @@ static struct pnp_driver ns558_pnp_drive
> static int __init ns558_init(void)
> {
> int i = 0;
> + int ret;
>
> /*
> * Probe for ISA ports.
> @@ -272,8 +273,8 @@ static int __init ns558_init(void)
> while (ns558_isa_portlist[i])
> ns558_isa_probe(ns558_isa_portlist[i++]);
>
> - pnp_register_driver(&ns558_pnp_driver);
> - return list_empty(&ns558_list) ? -ENODEV : 0;
> + ret = pnp_register_driver(&ns558_pnp_driver);
> + return (ret < 0) ? ret : 0;
> }
>
> static void __exit ns558_exit(void)
> _