Re: [PATCH] Linux joydev joystick disconnect patch 2.6.11-rc2

[Vojtech Pavlik <vojtech@suse.cz>]

On Mon, Feb 07, 2005 at 09:22:19AM -0500, Dmitry Torokhov wrote:

> On Mon, 7 Feb 2005 13:20:33 +0100, Vojtech Pavlik <vojtech@suse.cz> wrote:
> > On Sun, Feb 06, 2005 at 08:21:13PM -0500, Dmitry Torokhov wrote:
> > > > > Opening braces should go on the same line as the statement (if (...) {).
> > > >  
> > > > How about this patch?
> > >
> > > Looks fine now. Hmm, wait a sec... Don't we also need kill_fasync calls in
> > > disconnect routines as well?
> > 
> > This should do it:
> > 
> 
> Not quite...
> 
> > +               list_for_each_entry(list, &evdev->list, node)
> > +                       kill_fasync(&list->fasync, SIGIO, POLLHUP | POLLERR);
> 
> Wrong band constants - for SIGIO POLL_HUP and POLL_ERR should be used.

Obviously only one of them, since they're not designed for ORing. I used POLL_HUP then.

> /*
>  * SIGPOLL si_codes
>  */
> #define POLL_IN         (__SI_POLL|1)   /* data input available */
> #define POLL_OUT        (__SI_POLL|2)   /* output buffers available */
> #define POLL_MSG        (__SI_POLL|3)   /* input message available */
> #define POLL_ERR        (__SI_POLL|4)   /* i/o error */
> #define POLL_PRI        (__SI_POLL|5)   /* high priority input available */
> #define POLL_HUP        (__SI_POLL|6)   /* device disconnected */
 

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR