From: Adrian Bunk <bunk@stusta.de>
To: kkeil@suse.de, kai.germaschewski@gmx.de
Cc: isdn4linux@listserv.isdn4linux.de, linux-kernel@vger.kernel.org
Subject: [2.6 patch] drivers/isdn/tpam/: possible cleanups
Date: Wed, 9 Feb 2005 04:00:21 +0100 [thread overview]
Message-ID: <20050209030021.GF2978@stusta.de> (raw)
This patch makes the following possible cleanups:
- tpam_hdlc.c: make the needlessly global variable stuffs static
- tpam_nco.c: remove the unused global function build_ADestroyNCOReq
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/isdn/tpam/tpam.h | 1 -
drivers/isdn/tpam/tpam_hdlc.c | 2 +-
drivers/isdn/tpam/tpam_nco.c | 27 ---------------------------
3 files changed, 1 insertion(+), 29 deletions(-)
--- linux-2.6.11-rc3-mm1-full/drivers/isdn/tpam/tpam_hdlc.c.old 2005-02-09 03:39:54.000000000 +0100
+++ linux-2.6.11-rc3-mm1-full/drivers/isdn/tpam/tpam_hdlc.c 2005-02-09 03:40:02.000000000 +0100
@@ -548,7 +548,7 @@
static WORD * stuffs[] = { stuff0, stuff1, stuff2, stuff3, stuff4, stuff5 };
-WORD * destuffs[] = { destuff0, destuff1, destuff2, destuff3, destuff4, destuff5 };
+static WORD * destuffs[] = { destuff0, destuff1, destuff2, destuff3, destuff4, destuff5 };
/*- AuverTech Telecom -------------------------------------------------------+
--- linux-2.6.11-rc3-mm1-full/drivers/isdn/tpam/tpam.h.old 2005-02-09 03:40:16.000000000 +0100
+++ linux-2.6.11-rc3-mm1-full/drivers/isdn/tpam/tpam.h 2005-02-09 03:40:21.000000000 +0100
@@ -181,7 +181,6 @@
/* Function prototypes from tpam_nco.c */
extern struct sk_buff *build_ACreateNCOReq(const u8 *);
-extern struct sk_buff *build_ADestroyNCOReq(u32);
extern struct sk_buff *build_CConnectReq(u32, const u8 *, u8);
extern struct sk_buff *build_CConnectRsp(u32);
extern struct sk_buff *build_CDisconnectReq(u32);
--- linux-2.6.11-rc3-mm1-full/drivers/isdn/tpam/tpam_nco.c.old 2005-02-09 03:40:29.000000000 +0100
+++ linux-2.6.11-rc3-mm1-full/drivers/isdn/tpam/tpam_nco.c 2005-02-09 03:42:52.000000000 +0100
@@ -131,33 +131,6 @@
}
/*
- * Build a ADestroyNCOReq message.
- *
- * ncoid: the NCO id.
- *
- * Return: the sk_buff filled with the NCO packet, or NULL if error.
- */
-struct sk_buff *build_ADestroyNCOReq(u32 ncoid) {
- struct sk_buff *skb;
- u8 *tlv;
-
- pr_debug("TurboPAM(build_ADestroyNCOReq): ncoid=%lu\n",
- (unsigned long)ncoid);
-
- /* build the NCO packet */
- if (!(skb = build_NCOpacket(ID_ADestroyNCOReq, 6, 0, 0, 0)))
- return NULL;
-
- /* add the parameters */
- tlv = (u8 *)skb_put(skb, 6);
- *tlv = PAR_NCOID;
- *(tlv+1) = 4;
- *((u32 *)(tlv+2)) = ncoid;
-
- return skb;
-}
-
-/*
* Build a CConnectReq message.
*
* ncoid: the NCO id.
reply other threads:[~2005-02-09 3:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050209030021.GF2978@stusta.de \
--to=bunk@stusta.de \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=kai.germaschewski@gmx.de \
--cc=kkeil@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox