From: Andi Kleen <ak@muc.de>
To: Pekka Enberg <penberg@gmail.com>
Cc: Tom Zanussi <zanussi@us.ibm.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Greg KH <greg@kroah.com>, Andrew Morton <akpm@osdl.org>,
Roman Zippel <zippel@linux-m68k.org>,
Robert Wisniewski <bob@watson.ibm.com>,
Tim Bird <tim.bird@am.sony.com>,
Christoph Hellwig <hch@infradead.org>,
karim@opersys.com, penberg@cs.helsinki.fi
Subject: Re: [PATCH] relayfs redux, part 4
Date: 10 Feb 2005 10:09:03 +0100
Date: Thu, 10 Feb 2005 10:09:03 +0100 [thread overview]
Message-ID: <20050210090903.GA45994@muc.de> (raw)
In-Reply-To: <84144f02050209233314373462@mail.gmail.com>
>
> Please consider inlining alloc_page_array() and populate_page_array()
> into relay_alloc_rchan_buf() as they're only used once. You'd get rid
> of passing page_count as a pointer this way. If inlining is
> unacceptable, please at least move the n_pages calculation to
> relay_alloc_rchan_buf() to make the API more sane.
Modern gcc (3.3-hammer with unit-at-a-time or 3.4) will do that anyways on
its own.
-Andi
next prev parent reply other threads:[~2005-02-10 9:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-10 2:49 [PATCH] relayfs redux, part 4 Tom Zanussi
2005-02-10 6:30 ` Maneesh Soni
2005-02-10 6:49 ` Tom Zanussi
2005-02-10 7:33 ` Pekka Enberg
2005-02-10 9:09 ` Andi Kleen [this message]
2005-02-10 9:14 ` Pekka J Enberg
2005-02-10 7:52 ` [PATCH] " Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050210090903.GA45994@muc.de \
--to=ak@muc.de \
--cc=akpm@osdl.org \
--cc=bob@watson.ibm.com \
--cc=greg@kroah.com \
--cc=hch@infradead.org \
--cc=karim@opersys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=penberg@gmail.com \
--cc=tim.bird@am.sony.com \
--cc=zanussi@us.ibm.com \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox