From: Pete Zaitcev <zaitcev@redhat.com>
To: Dmitry Torokhov <dtor_core@ameritech.net>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix ALPS sync loss
Date: Thu, 10 Feb 2005 11:07:46 -0800 [thread overview]
Message-ID: <20050210110746.1c779ffd@localhost.localdomain> (raw)
In-Reply-To: <mailman.1107906420.26313.linux-kernel2news@redhat.com>
On Tue, 8 Feb 2005 18:40:12 -0500, Dmitry Torokhov <dtor_core@ameritech.net> wrote:
> Here is the promised patch. It turns out protocol validation code was
> a bit (or rather a byte ;) ) off.
> +++ b/drivers/input/mouse/alps.c 2005-02-08 18:16:27 -05:00
> @@ -198,8 +198,8 @@
> return PSMOUSE_BAD_DATA;
>
> /* Bytes 2 - 6 should have 0 in the highest bit */
> - if (psmouse->pktcnt > 1 && psmouse->pktcnt <= 6 &&
> - (psmouse->packet[psmouse->pktcnt] & 0x80))
> + if (psmouse->pktcnt >= 2 && psmouse->pktcnt <= 6 &&
> + (psmouse->packet[psmouse->pktcnt - 1] & 0x80))
> return PSMOUSE_BAD_DATA;
This seems to work here, no more dead pad.
-- Pete
next parent reply other threads:[~2005-02-10 19:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.1107906420.26313.linux-kernel2news@redhat.com>
2005-02-10 19:07 ` Pete Zaitcev [this message]
2005-02-08 23:40 [PATCH] Fix ALPS sync loss Dmitry Torokhov
2005-02-09 7:23 ` Vojtech Pavlik
2005-02-09 17:35 ` Joseph Pingenot
2005-02-10 19:54 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050210110746.1c779ffd@localhost.localdomain \
--to=zaitcev@redhat.com \
--cc=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox