From: Andi Kleen <ak@muc.de>
To: Piotr Kaczuba <pepe@attika.ath.cx>
Cc: linux-kernel@vger.kernel.org, greg@kroah.com, tom.l.nguyen@intel.com
Subject: Re: PCI access mode on x86_64
Date: 14 Feb 2005 13:02:05 +0100
Date: Mon, 14 Feb 2005 13:02:05 +0100 [thread overview]
Message-ID: <20050214120205.GA33348@muc.de> (raw)
In-Reply-To: <20050214094701.GA323@attika.ath.cx>
On Mon, Feb 14, 2005 at 10:47:01AM +0100, Piotr Kaczuba wrote:
> On Mon, Feb 14, 2005 at 10:18:43AM +0100, Andi Kleen wrote:
> > Piotr Kaczuba <pepe@attika.ath.cx> writes:
> > > Is there a reason why "PCI access mode" config option isn't available for
> > > x86_64? Due to this, PCIE config options aren't available either.
> >
> > There is no 64bit PCI BIOS, so access is always direct.
> >
> > I assume you mean mmconfig access with "PCIE config options", that is
> > a separate config option and available.
>
> I mean the PCIEPORTBUS option which depends on PCI_GOMMCONFIG or
> PCI_GOANY. I assume that due to PCI_MMCONFIG / PCI_GOMMCONFIG mismatch
> it's not available on x86_64.
Ok, that's a bug in PCIEPORTBUS. Best is probably to
completely remove the dependency, it doesn't make much sense
(the code has to handle the case of mmconfig not being available at
runtime anyways)
-Andi
Remove bogus dependency in PCI Express root driver.
Signed-off-by: Andi Kleen <ak@suse.de>
diff -u linux-2.6.11rc3/drivers/pci/pcie/Kconfig-o linux-2.6.11rc3/drivers/pci/pcie/Kconfig
--- linux-2.6.11rc3/drivers/pci/pcie/Kconfig-o 2005-02-04 09:13:10.000000000 +0100
+++ linux-2.6.11rc3/drivers/pci/pcie/Kconfig 2005-02-14 12:59:46.000000000 +0100
@@ -3,7 +3,6 @@
#
config PCIEPORTBUS
bool "PCI Express support"
- depends on PCI_GOMMCONFIG || PCI_GOANY
default n
---help---
next prev parent reply other threads:[~2005-02-14 12:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-13 21:31 PCI access mode on x86_64 Piotr Kaczuba
2005-02-14 9:18 ` Andi Kleen
2005-02-14 9:47 ` Piotr Kaczuba
2005-02-14 12:02 ` Andi Kleen [this message]
2005-02-14 15:46 ` Piotr Kaczuba
2005-02-14 19:15 ` Andi Kleen
2005-02-17 23:18 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050214120205.GA33348@muc.de \
--to=ak@muc.de \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pepe@attika.ath.cx \
--cc=tom.l.nguyen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox