public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@suse.cz>
To: Andrew Morton <akpm@osdl.org>
Cc: ncunningham@cyclades.com, bernard@blackham.com.au,
	torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Fix u32 vs. pm_message_t confusion in OSS
Date: Tue, 15 Feb 2005 01:41:52 +0100	[thread overview]
Message-ID: <20050215004151.GC5415@elf.ucw.cz> (raw)
In-Reply-To: <20050214134658.324076c9.akpm@osdl.org>

Hi!

This fixes (part of) u32 vs. pm_message_t confusion in OSS. I found no
maintainer for OSS in MAINTAINERS, that's why it goes to you... It
should cause no code changes. Please apply,

                                                                Pavel


--- clean-mm/sound/oss/ali5455.c	2005-02-15 00:34:42.000000000 +0100
+++ linux-mm/sound/oss/ali5455.c	2005-02-15 01:04:11.000000000 +0100
@@ -3528,7 +3528,7 @@
 }
 
 #ifdef CONFIG_PM
-static int ali_pm_suspend(struct pci_dev *dev, u32 pm_state)
+static int ali_pm_suspend(struct pci_dev *dev, pm_message_t pm_state)
 {
 	struct ali_card *card = pci_get_drvdata(dev);
 	struct ali_state *state;
--- clean-mm/sound/oss/cs4281/cs4281_wrapper-24.c	2005-02-15 00:34:42.000000000 +0100
+++ linux-mm/sound/oss/cs4281/cs4281_wrapper-24.c	2005-02-15 01:04:11.000000000 +0100
@@ -27,7 +27,7 @@
 #include <linux/spinlock.h>
 
 static int cs4281_resume_null(struct pci_dev *pcidev) { return 0; }
-static int cs4281_suspend_null(struct pci_dev *pcidev, u32 state) { return 0; }
+static int cs4281_suspend_null(struct pci_dev *pcidev, pm_message_t state) { return 0; }
 
 #define free_dmabuf(state, dmabuf) \
 	pci_free_consistent(state->pcidev, \
--- clean-mm/sound/oss/cs46xx.c	2005-02-15 00:34:42.000000000 +0100
+++ linux-mm/sound/oss/cs46xx.c	2005-02-15 01:04:11.000000000 +0100
@@ -388,7 +388,7 @@
 static int cs46xx_powerup(struct cs_card *card, unsigned int type);
 static int cs461x_powerdown(struct cs_card *card, unsigned int type, int suspendflag);
 static void cs461x_clear_serial_FIFOs(struct cs_card *card, int type);
-static int cs46xx_suspend_tbl(struct pci_dev *pcidev, u32 state);
+static int cs46xx_suspend_tbl(struct pci_dev *pcidev, pm_message_t state);
 static int cs46xx_resume_tbl(struct pci_dev *pcidev);
 
 #ifndef CS46XX_ACPI_SUPPORT
@@ -5774,7 +5774,7 @@
 #endif
 
 #if CS46XX_ACPI_SUPPORT
-static int cs46xx_suspend_tbl(struct pci_dev *pcidev, u32 state)
+static int cs46xx_suspend_tbl(struct pci_dev *pcidev, pm_message_t state)
 {
 	struct cs_card *s = PCI_GET_DRIVER_DATA(pcidev);
 	CS_DBGOUT(CS_PM | CS_FUNCTION, 2, 
--- clean-mm/sound/oss/cs46xxpm-24.h	2005-02-15 00:34:42.000000000 +0100
+++ linux-mm/sound/oss/cs46xxpm-24.h	2005-02-15 01:04:11.000000000 +0100
@@ -36,7 +36,7 @@
 * for now (12/22/00) only enable the pm_register PM support.
 * allow these table entries to be null.
 */
-static int cs46xx_suspend_tbl(struct pci_dev *pcidev, u32 state);
+static int cs46xx_suspend_tbl(struct pci_dev *pcidev, pm_message_t state);
 static int cs46xx_resume_tbl(struct pci_dev *pcidev);
 #define cs_pm_register(a, b, c)  NULL
 #define cs_pm_unregister_all(a) 
--- clean-mm/sound/oss/esssolo1.c	2004-12-25 13:35:04.000000000 +0100
+++ linux-mm/sound/oss/esssolo1.c	2005-02-15 01:04:11.000000000 +0100
@@ -2257,7 +2257,7 @@
 }
 
 static int
-solo1_suspend(struct pci_dev *pci_dev, u32 state) {
+solo1_suspend(struct pci_dev *pci_dev, pm_message_t state) {
 	struct solo1_state *s = (struct solo1_state*)pci_get_drvdata(pci_dev);
 	if (!s)
 		return 1;
--- clean-mm/sound/oss/i810_audio.c	2005-02-15 00:34:42.000000000 +0100
+++ linux-mm/sound/oss/i810_audio.c	2005-02-15 01:04:11.000000000 +0100
@@ -3470,7 +3470,7 @@
 }
 
 #ifdef CONFIG_PM
-static int i810_pm_suspend(struct pci_dev *dev, u32 pm_state)
+static int i810_pm_suspend(struct pci_dev *dev, pm_message_t pm_state)
 {
         struct i810_card *card = pci_get_drvdata(dev);
         struct i810_state *state;
--- clean-mm/sound/oss/maestro3.c	2005-02-15 00:34:42.000000000 +0100
+++ linux-mm/sound/oss/maestro3.c	2005-02-15 01:04:11.000000000 +0100
@@ -375,7 +375,7 @@
  * I'm not very good at laying out functions in a file :)
  */
 static int m3_notifier(struct notifier_block *nb, unsigned long event, void *buf);
-static int m3_suspend(struct pci_dev *pci_dev, u32 state);
+static int m3_suspend(struct pci_dev *pci_dev, pm_message_t state);
 static void check_suspend(struct m3_card *card);
 
 static struct notifier_block m3_reboot_nb = {
@@ -2777,12 +2777,12 @@
 
     for(card = devs; card != NULL; card = card->next) {
         if(!card->in_suspend)
-            m3_suspend(card->pcidev, 3); /* XXX legal? */
+            m3_suspend(card->pcidev, PMSG_SUSPEND); /* XXX legal? */
     }
     return 0;
 }
 
-static int m3_suspend(struct pci_dev *pci_dev, u32 state)
+static int m3_suspend(struct pci_dev *pci_dev, pm_message_t state)
 {
     unsigned long flags;
     int i;
--- clean-mm/sound/oss/trident.c	2005-02-15 00:34:42.000000000 +0100
+++ linux-mm/sound/oss/trident.c	2005-02-15 01:04:11.000000000 +0100
@@ -487,7 +487,7 @@
 static struct trident_channel *ali_alloc_pcm_channel(struct trident_card *card);
 static void ali_restore_regs(struct trident_card *card);
 static void ali_save_regs(struct trident_card *card);
-static int trident_suspend(struct pci_dev *dev, u32 unused);
+static int trident_suspend(struct pci_dev *dev, pm_message_t unused);
 static int trident_resume(struct pci_dev *dev);
 static void ali_free_pcm_channel(struct trident_card *card, unsigned int channel);
 static int ali_setup_multi_channels(struct trident_card *card, int chan_nums);
@@ -3723,7 +3723,7 @@
 }
 
 static int
-trident_suspend(struct pci_dev *dev, u32 unused)
+trident_suspend(struct pci_dev *dev, pm_message_t unused)
 {
 	struct trident_card *card = pci_get_drvdata(dev);
 
--- clean-mm/sound/oss/ymfpci.c	2005-02-15 00:34:42.000000000 +0100
+++ linux-mm/sound/oss/ymfpci.c	2005-02-15 01:04:11.000000000 +0100
@@ -2074,7 +2074,7 @@
 /*
  */
 
-static int ymf_suspend(struct pci_dev *pcidev, u32 unused)
+static int ymf_suspend(struct pci_dev *pcidev, pm_message_t unused)
 {
 	struct ymf_unit *unit = pci_get_drvdata(pcidev);
 	unsigned long flags;

-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!

  parent reply	other threads:[~2005-02-15  0:42 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-14  5:43 PATCH: Address lots of pending pm_message_t changes Nigel Cunningham
2005-02-14 21:34 ` Pavel Machek
2005-02-14 21:46   ` Andrew Morton
2005-02-14 21:57     ` Nigel Cunningham
2005-02-14 22:04       ` Pavel Machek
2005-02-14 22:09         ` Nigel Cunningham
2005-02-14 23:41           ` Pavel Machek
2005-02-15  0:15             ` Nigel Cunningham
2005-02-15  0:15               ` Pavel Machek
2005-02-15  0:21                 ` Nigel Cunningham
2005-02-15  1:13               ` Bernard Blackham
2005-02-15  0:31     ` Fix pm_message_t in generic code [was Re: PATCH: Address lots of pending pm_message_t changes] Pavel Machek
2005-02-15  0:46       ` Nigel Cunningham
2005-02-15  0:39     ` Fix u32 vs. pm_message_t in USB " Pavel Machek
2005-02-17 23:40       ` Greg KH
2005-02-28  1:24         ` Pavel Machek
2005-02-15  0:41     ` Pavel Machek [this message]
2005-02-15  0:46     ` Fix u32 vs. pm_message_t confusion in PCMCIA Pavel Machek
2005-02-15  0:47     ` FIx u32 vs. pm_message_t confusion in firewire Pavel Machek
2005-02-15 22:12       ` Jody McIntyre
2005-02-15  0:51     ` Fix u32 vs. pm_message_t in network device drivers Pavel Machek
2005-02-15  0:54     ` Fix u32 vs. pm_message_t confusion in framebuffers Pavel Machek
2005-02-15  0:55     ` Fix u32 vs. pm_message_t in i8042.c Pavel Machek
2005-02-15 13:10       ` Vojtech Pavlik
2005-02-15  0:57     ` Fix u32 vs. pm_message_t confusion in MMC Pavel Machek
2005-02-15  0:58     ` Fix u32 vs. pm_message_t confusion in serials Pavel Machek
2005-02-15  1:00     ` Fix u32 vs. pm_message_t in macintosh Pavel Machek
2005-02-15  1:00     ` Fix u32 vs. pm_message_t confusion in bttv Pavel Machek
2005-02-15  1:01     ` Fix u32 vs. pm_message_t confusion in AGP Pavel Machek
2005-02-14 21:46 ` PATCH: Address lots of pending pm_message_t changes Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050215004151.GC5415@elf.ucw.cz \
    --to=pavel@suse.cz \
    --cc=akpm@osdl.org \
    --cc=bernard@blackham.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ncunningham@cyclades.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox