From: Andi Kleen <ak@suse.de>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Andi Kleen <ak@suse.de>,
linux-kernel@vger.kernel.org, paulus@samba.org, anton@samba.org,
davem@davemloft.net, ralf@linux-mips.org, tony.luck@intel.com,
willy@debian.org, schwidefsky@de.ibm.com
Subject: Re: [PATCH] Consolidate compat_sys_waitid
Date: Tue, 15 Feb 2005 12:10:35 +0100 [thread overview]
Message-ID: <20050215111035.GD2623@wotan.suse.de> (raw)
In-Reply-To: <20050215220614.68c4e11e.sfr@canb.auug.org.au>
On Tue, Feb 15, 2005 at 10:06:14PM +1100, Stephen Rothwell wrote:
> Hi Andi,
>
> On Tue, 15 Feb 2005 10:51:53 +0100 Andi Kleen <ak@suse.de> wrote:
> >
> > I don't think this will work for sparc64/s390/UML etc.
> > They cannot access kernel data inside KERNEL_DS. You would need to use
> > compat_alloc_user_space() for ru
>
> .. and, presumably, for info as well. Interestingly, this code
> came directly from sparc64 ...
Sorry, I misread the code. In this case it's actually ok.
The only thing that doesn't work is mixing the pointers (e.g. accessing
user mode pointers inside KERNEL_DS)
So the patch is fine.
-Andi
next prev parent reply other threads:[~2005-02-15 11:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-15 3:01 [PATCH] Consolidate compat_sys_waitid Stephen Rothwell
2005-02-15 9:51 ` Andi Kleen
2005-02-15 11:06 ` Stephen Rothwell
2005-02-15 11:10 ` Andi Kleen [this message]
2005-02-15 18:37 ` David S. Miller
2005-02-15 18:43 ` Matthew Wilcox
2005-02-15 19:23 ` Andi Kleen
2005-02-15 19:27 ` Al Viro
2005-02-18 5:22 ` Stephen Rothwell
2005-02-15 19:33 ` Daniel Jacobowitz
2005-02-16 0:06 ` Paul Mackerras
-- strict thread matches above, loose matches on Subject: below --
2005-02-15 18:09 Luck, Tony
2005-03-07 1:08 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050215111035.GD2623@wotan.suse.de \
--to=ak@suse.de \
--cc=anton@samba.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
--cc=schwidefsky@de.ibm.com \
--cc=sfr@canb.auug.org.au \
--cc=tony.luck@intel.com \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox