public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@sgi.com>
To: akpm@osdl.org, benh@kernel.crashing.org, linux-kernel@vger.kernel.org
Subject: [PATCH] quiet non-x86 option ROM warnings
Date: Tue, 15 Feb 2005 15:57:05 -0800	[thread overview]
Message-ID: <200502151557.06049.jbarnes@sgi.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 458 bytes --]

Both the r128 and radeon drivers complain if they don't find an x86 option ROM 
on the device they're talking to.  This would be fine, except that the 
message is incorrect--not all option ROMs are required to be x86 based.  This 
small patch just removes the messages altogether, causing the drivers to 
*silently* fall back to the non-x86 option ROM behavior (it works fine and 
there's no cause for alarm).

Signed-off-by: Jesse Barnes <jbarnes@sgi.com>


[-- Attachment #2: non-x86-rom-ok.patch --]
[-- Type: text/x-diff, Size: 1226 bytes --]

===== drivers/video/aty/radeon_base.c 1.39 vs edited =====
--- 1.39/drivers/video/aty/radeon_base.c	2005-02-10 22:57:44 -08:00
+++ edited/drivers/video/aty/radeon_base.c	2005-02-15 15:51:19 -08:00
@@ -329,11 +329,9 @@
 	rinfo->bios_seg = rom;
 
 	/* Very simple test to make sure it appeared */
-	if (BIOS_IN16(0) != 0xaa55) {
-		printk(KERN_ERR "radeonfb (%s): Invalid ROM signature %x should be"
-		       "0xaa55\n", pci_name(rinfo->pdev), BIOS_IN16(0));
-		goto failed;
-	}
+	if (BIOS_IN16(0) != 0xaa55)
+		goto failed; /* not an x86 option ROM, bail out */
+
 	/* Look for the PCI data to check the ROM type */
 	dptr = BIOS_IN16(0x18);
 
===== drivers/video/aty/aty128fb.c 1.56 vs edited =====
--- 1.56/drivers/video/aty/aty128fb.c	2005-02-10 22:57:44 -08:00
+++ edited/drivers/video/aty/aty128fb.c	2005-02-15 15:51:40 -08:00
@@ -812,11 +812,8 @@
 	}
 
 	/* Very simple test to make sure it appeared */
-	if (BIOS_IN16(0) != 0xaa55) {
-		printk(KERN_ERR "aty128fb: Invalid ROM signature %x should be 0xaa55\n",
-		       BIOS_IN16(0));
-		goto failed;
-	}
+	if (BIOS_IN16(0) != 0xaa55)
+		goto failed; /* not an x86 option ROM, bail out */
 
 	/* Look for the PCI data to check the ROM type */
 	dptr = BIOS_IN16(0x18);

             reply	other threads:[~2005-02-15 23:57 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-15 23:57 Jesse Barnes [this message]
2005-02-16  0:36 ` [PATCH] quiet non-x86 option ROM warnings Jon Smirl
2005-02-16  0:45   ` Jesse Barnes
2005-02-16  1:00     ` Benjamin Herrenschmidt
2005-02-16  1:00     ` Benjamin Herrenschmidt
2005-02-16  1:08       ` Jon Smirl
2005-02-16  1:57         ` Jesse Barnes
2005-02-16  4:00         ` Benjamin Herrenschmidt
2005-02-16  1:03 ` Benjamin Herrenschmidt
2005-02-16 23:54   ` Jesse Barnes
2005-02-17  0:48     ` Benjamin Herrenschmidt
2005-02-17 16:33       ` Jon Smirl
2005-02-17 17:29         ` Jesse Barnes
2005-02-17 17:32           ` Jon Smirl
2005-02-17 17:41             ` Jesse Barnes
2005-02-17 17:45             ` Jesse Barnes
2005-02-17 17:56               ` Jon Smirl
2005-02-17 22:48                 ` Benjamin Herrenschmidt
2005-02-17 22:47               ` Benjamin Herrenschmidt
2005-02-17 22:59                 ` Jon Smirl
2005-02-17 23:00                   ` Jesse Barnes
2005-02-17 23:04                   ` Benjamin Herrenschmidt
2005-02-17 23:20                   ` Andrew Vasquez
2005-02-17 22:45         ` Benjamin Herrenschmidt
2005-02-17 22:56           ` Jon Smirl
2005-02-18 12:09             ` Gabriel Paubert
2005-02-18 16:50               ` Jon Smirl
2005-09-04 13:27 ` Olaf Hering
2005-09-04 14:20   ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200502151557.06049.jbarnes@sgi.com \
    --to=jbarnes@sgi.com \
    --cc=akpm@osdl.org \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox