From: Jesse Barnes <jbarnes@sgi.com>
To: Jon Smirl <jonsmirl@gmail.com>
Cc: akpm@osdl.org, benh@kernel.crashing.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] quiet non-x86 option ROM warnings
Date: Tue, 15 Feb 2005 16:45:27 -0800 [thread overview]
Message-ID: <200502151645.27774.jbarnes@sgi.com> (raw)
In-Reply-To: <9e473391050215163621dafa65@mail.gmail.com>
On Tuesday, February 15, 2005 4:36 pm, Jon Smirl wrote:
> You're removing the check for 55AA at the start of the ROM.
No, the check is still there, I just removed the printk if 0xaa55 isn't found
(my box returns 0x303 instead).
> I though
> the PCI standard was that all ROMs had to start with the no matter
> what object code they contain. Then if you look for PCIR there is a
> field in the stucture that says what language the ROM is in. Maybe the
> problem is in the BIOS_IN16() function and things are getting byte
> swapped wrong.
I thought the signature described what type of ROM was there? E.g. 0xaa55
means x86 ROM, x0303 means OF ROM, etc.?
At any rate, not having a ROM at all (which my case may be) isn't an error
either, so I think removing the printk is appropriate regardless.
Thanks,
Jesse
next prev parent reply other threads:[~2005-02-16 0:45 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-15 23:57 [PATCH] quiet non-x86 option ROM warnings Jesse Barnes
2005-02-16 0:36 ` Jon Smirl
2005-02-16 0:45 ` Jesse Barnes [this message]
2005-02-16 1:00 ` Benjamin Herrenschmidt
2005-02-16 1:00 ` Benjamin Herrenschmidt
2005-02-16 1:08 ` Jon Smirl
2005-02-16 1:57 ` Jesse Barnes
2005-02-16 4:00 ` Benjamin Herrenschmidt
2005-02-16 1:03 ` Benjamin Herrenschmidt
2005-02-16 23:54 ` Jesse Barnes
2005-02-17 0:48 ` Benjamin Herrenschmidt
2005-02-17 16:33 ` Jon Smirl
2005-02-17 17:29 ` Jesse Barnes
2005-02-17 17:32 ` Jon Smirl
2005-02-17 17:41 ` Jesse Barnes
2005-02-17 17:45 ` Jesse Barnes
2005-02-17 17:56 ` Jon Smirl
2005-02-17 22:48 ` Benjamin Herrenschmidt
2005-02-17 22:47 ` Benjamin Herrenschmidt
2005-02-17 22:59 ` Jon Smirl
2005-02-17 23:00 ` Jesse Barnes
2005-02-17 23:04 ` Benjamin Herrenschmidt
2005-02-17 23:20 ` Andrew Vasquez
2005-02-17 22:45 ` Benjamin Herrenschmidt
2005-02-17 22:56 ` Jon Smirl
2005-02-18 12:09 ` Gabriel Paubert
2005-02-18 16:50 ` Jon Smirl
2005-09-04 13:27 ` Olaf Hering
2005-09-04 14:20 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200502151645.27774.jbarnes@sgi.com \
--to=jbarnes@sgi.com \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=jonsmirl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox